Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all missing entries in internationalization files. #1535

Merged

Conversation

usingtechnology
Copy link
Collaborator

Description

Addresses FORMS-1326 (External API i18n) and FORMS-1549 (Event Stream i18n).
For all languages, fill in all empty resource entries.

Type of Change

  • removed duplicate user entry in en.json
  • for most languages removed a duplicate preview entry
  • all entries in en.json now have a corresponding entry in each language (Google Translate API translation)
  • all previous entries were left alone.
  • the test.customError was not translated for any language.

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

Copy link
Collaborator

@abhilash-aot abhilash-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n changes looks good

@usingtechnology usingtechnology merged commit 4582746 into bcgov:main Dec 4, 2024
5 checks passed
"create": "Créer une nouvelle API externe.",
"createError": "L'API externe n'a pas pu être créée.",
"createSuccess": "API externe créée avec succès.",
"createTitle": "Nouvelle configuration de l'API externe",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason accented characters are being encoded in two different ways. One way isn't working.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants