Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FORMS-1326 follow up. Html Code for apostrophe not rendered correctly. #1538

Merged
merged 2 commits into from
Dec 5, 2024
Merged

FORMS-1326 follow up. Html Code for apostrophe not rendered correctly. #1538

merged 2 commits into from
Dec 5, 2024

Conversation

usingtechnology
Copy link
Collaborator

Description

Follow up to #1535.
HTML Codes are rendered, not interpreted by i18n library. Replace the HTML code ' with apostrophes.

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@usingtechnology usingtechnology merged commit 63fd4bd into bcgov:main Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanBirtch-aot RyanBirtch-aot RyanBirtch-aot approved these changes

@WalterMoar WalterMoar Awaiting requested review from WalterMoar

@abhilash-aot abhilash-aot Awaiting requested review from abhilash-aot

@jasonchung1871 jasonchung1871 Awaiting requested review from jasonchung1871

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usingtechnology @RyanBirtch-aot