Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sign Field to Observation Subcounts #1354

Merged
merged 10 commits into from
Sep 10, 2024

Merge branch 'dev' into observation-sign

d96dbf4
Select commit
Loading
Failed to load commit list.
Merged

Add Sign Field to Observation Subcounts #1354

Merge branch 'dev' into observation-sign
d96dbf4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 1s

48.34% (+2.02%) compared to 407efe1

View this Pull Request on Codecov

48.34% (+2.02%) compared to 407efe1

Details

Codecov Report

Attention: Patch coverage is 31.53153% with 76 lines in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (407efe1) to head (d96dbf4).

Files with missing lines Patch % Lines
api/src/services/observation-service.ts 5.66% 50 Missing ⚠️
...ies/observation-subcount-environment-repository.ts 0.00% 8 Missing ⚠️
.../observations-table/ObservationsTableContainer.tsx 0.00% 6 Missing ⚠️
.../grid-column-definitions/GridColumnDefinitions.tsx 16.66% 5 Missing ⚠️
...rvices/observation-subcount-environment-service.ts 0.00% 4 Missing ⚠️
api/src/paths/reference/search/environment.ts 0.00% 1 Missing ⚠️
api/src/utils/xlsx-utils/worksheet-utils.ts 50.00% 1 Missing ⚠️
...tions/sampling-sites/SamplingSiteListContainer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1354      +/-   ##
==========================================
+ Coverage   46.32%   48.34%   +2.02%     
==========================================
  Files         762      763       +1     
  Lines       20410    20498      +88     
  Branches     3121     3134      +13     
==========================================
+ Hits         9454     9909     +455     
- Misses      10378    10437      +59     
+ Partials      578      152     -426

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov