Add Sign Field to Observation Subcounts

[mauberti-bc]

Links to Jira Tickets

• N/A

Description of Changes

• Adds "observation_subcount_sign" to the observations table (the database field was added in an previous migration)
• Includes "sign" as a supported column in the observation CSV validator

Testing Notes

• Should be able to import observations from a csv file with a "Sign" column, and add observations with a sign value manually.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1354-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1354-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1354

[codecov]

Codecov Report

Attention: Patch coverage is 31.53153% with 76 lines in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (407efe1) to head (d96dbf4).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
api/src/services/observation-service.ts	5.66%	50 Missing ⚠️
...ies/observation-subcount-environment-repository.ts	0.00%	8 Missing ⚠️
.../observations-table/ObservationsTableContainer.tsx	0.00%	6 Missing ⚠️
.../grid-column-definitions/GridColumnDefinitions.tsx	16.66%	5 Missing ⚠️
...rvices/observation-subcount-environment-service.ts	0.00%	4 Missing ⚠️
api/src/paths/reference/search/environment.ts	0.00%	1 Missing ⚠️
api/src/utils/xlsx-utils/worksheet-utils.ts	50.00%	1 Missing ⚠️
...tions/sampling-sites/SamplingSiteListContainer.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1354      +/-   ##
==========================================
+ Coverage   46.32%   48.34%   +2.02%     
==========================================
  Files         762      763       +1     
  Lines       20410    20498      +88     
  Branches     3121     3134      +13     
==========================================
+ Hits         9454     9909     +455     
- Misses      10378    10437      +59     
+ Partials      578      152     -426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1354-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1354-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1354

[NickPhura]

@mauberti-bc Minor: Is there a description for the observation sign column?
In GridColumnDefinitions.tsx -> ObservationSubcountSignColDef

[mauberti-bc]

@mauberti-bc Minor: Is there a description for the observation sign column? In GridColumnDefinitions.tsx -> ObservationSubcountSignColDef

Good catch: "The observed evidence of the species"

[NickPhura]

@mauberti-bc

Added backend validation for the sign field when importing a csv.

Added some missing backend validation for manual observation records (we weren't validating environment columns before).

I also fixed a bug that prevented quantitative environment fields from being returned in the search (when adding columns to the observation table).

I believe everything is working as expected, but if you have time to give it a quick manual test as well, that would be valuable.

[mauberti-bc]

@mauberti-bc

Added backend validation for the sign field when importing a csv.

Added some missing backend validation for manual observation records (we weren't validating environment columns before).

I also fixed a bug that prevented quantitative environment fields from being returned in the search (when adding columns to the observation table).

I believe everything is working as expected, but if you have time to give it a quick manual test as well, that would be valuable.

Awesome. I'll test it now

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

[NickPhura]

🦌