BugFix: Fix Pipeline Issue

.github/workflows/cleanClosedPR.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo

.github/workflows/cleanMergedPR.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo

.github/workflows/deploy.yml

@@ -128,7 +128,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
   # Build the web frontend app image
   buildAPP:
@@ -151,7 +151,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -213,7 +213,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -274,7 +274,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -330,7 +330,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -390,7 +390,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -444,7 +444,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -499,7 +499,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -556,7 +556,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo

.github/workflows/deployStatic.yml

@@ -67,7 +67,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Checkout Target Branch
         uses: actions/checkout@v4
@@ -101,7 +101,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -151,7 +151,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -201,7 +201,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -251,7 +251,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -302,7 +302,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -353,7 +353,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -405,7 +405,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -457,7 +457,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -510,7 +510,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo

.github/workflows/e2e-pr-test.yml

@@ -56,7 +56,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       - name: E2E Smoke tests
         uses: cypress-io/github-action@v6

.github/workflows/lint-format.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Checkout Target Branch
         uses: actions/checkout@v4
@@ -50,7 +50,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -81,7 +81,7 @@ jobs:
 
       - name: Install api dependencies
         working-directory: api
-        run: npm install
+        run: npm ci --include=dev
 
       - name: Run api linter
         working-directory: api
@@ -105,7 +105,7 @@ jobs:
 
       - name: Install app dependencies
         working-directory: app
-        run: npm install
+        run: npm ci --include=dev
 
       - name: Run app linter
         working-directory: app
@@ -129,7 +129,7 @@ jobs:
 
       - name: Install database dependencies
         working-directory: database
-        run: npm install
+        run: npm ci --include=dev
 
       - name: Run database linter
         working-directory: database

.github/workflows/test.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       - name: Checkout Target Branch
         uses: actions/checkout@v4
@@ -53,7 +53,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       # Load repo from cache
       - name: Cache repo
@@ -84,7 +84,7 @@ jobs:
 
       - name: Install api dependencies
         working-directory: api
-        run: npm install
+        run: npm ci --include=dev
 
       - name: Run api tests with coverage
         working-directory: api
@@ -110,7 +110,7 @@ jobs:
 
       - name: Install app dependencies
         working-directory: app
-        run: npm install
+        run: npm ci --include=dev
 
       - name: Run app tests with coverage
         working-directory: app

README/Pipeline.md

@@ -0,0 +1,33 @@
+# Pipeline Readme
+
+## Troubleshooting
+
+### Your cache folder contains root-owned files, due to a bug in previous versions of which has since been addressed.
+
+```Bash
+npm ERR! code EACCES
+npm ERR! sysca11 open
+npm ERR! path /opt/app—root/src/
+npm ERR! errno —13
+npm ERR!
+npm ERR! Your cache folder contains files, due to a bug in
+npm ERR! previous versions of which has since been addressed.
+npm ERR!
+npm ERR! To fix this problem, please run:
+npm ERR! sudo cho•m -R "/opt/app-root/src/.npn"
+```
+
+#### Solution Adopted By This Repo
+
+Update api/app `Dockerfile` to a multi-stage build where the `.npm` folder is not copied from stage 1 into stage 2 AND
+the application is started by calling `node <file>` rather than `npm run <command>`, thereby bypassing npm entirely.
+
+#### Misc related documentation/threads
+
+##### Openshift
+
+- https://docs.openshift.com/container-platform/4.14/openshift_images/create-images.html#use-uid_create-images
+
+##### Rocketchat
+
+- https://chat.developer.gov.bc.ca/channel/devops-how-to/thread/vxnNGi8fJBqT6mmas

api/.docker/api/Dockerfile

@@ -2,7 +2,7 @@
 # This DockerFile is used for local development (via docker-compose) only.
 # ########################################################################################################
 
-FROM node:18
+FROM node:20
 
 ENV HOME=/opt/app-root/src
 
@@ -14,9 +14,7 @@ WORKDIR $HOME
 # A wildcard is used to ensure both package.json AND package-lock.json are copied where available (npm@5+)
 COPY package*.json ./
 
-# If you are building your code for production
-# RUN npm install --only=production
-RUN npm install
+RUN npm ci --include=dev
 
 ENV PATH ${HOME}/node_modules/.bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:$PATH
 

api/.pipeline/templates/api.bc.yaml

@@ -29,13 +29,13 @@ parameters:
     value: dev
   - name: BASE_IMAGE_URL
     required: true
-    value: image-registry.openshift-image-registry.svc:5000/openshift/nodejs-18:1-98.1711398651
+    value: image-registry.openshift-image-registry.svc:5000/openshift/nodejs:latest
   - name: SOURCE_IMAGE_NAME
     required: true
-    value: nodejs-18
+    value: nodejs
   - name: SOURCE_IMAGE_TAG
     required: true
-    value: 1-98.1711398651
+    value: latest
   - name: CPU_REQUEST
     value: '50m'
   - name: CPU_LIMIT