Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fix Pipeline Issue #1295

Merged
merged 2 commits into from
May 31, 2024
Merged

BugFix: Fix Pipeline Issue #1295

merged 2 commits into from
May 31, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented May 30, 2024

Links to Jira Tickets

n/a

Originally prompted by:

image

Description of Changes

Update api/app dockerfiles

Add tsconfig.production.ts and .env.production to the api and app respectively, to remove tests and sourcemaps from the deployed build

Update to node 20

Bump typescript version

Testing Notes

Should build, deploy, and runs as normal both locally and in Openshift.

@NickPhura NickPhura requested review from MacQSL and mauberti-bc May 30, 2024 23:16
Update to node 20
Bump typescript version
@NickPhura NickPhura force-pushed the np_techdebt_pipeline_2 branch from c8ddc02 to 6e2feb0 Compare May 30, 2024 23:25
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.66%. Comparing base (80c9c2f) to head (c7c37ba).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1295   +/-   ##
=======================================
  Coverage   52.66%   52.66%           
=======================================
  Files         581      581           
  Lines       16763    16763           
  Branches     2601     2601           
=======================================
  Hits         8829     8829           
  Misses       7344     7344           
  Partials      590      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as draft May 30, 2024 23:37
@NickPhura NickPhura added the Ready For Review PR is ready for review label May 30, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@NickPhura NickPhura marked this pull request as ready for review May 31, 2024 19:03
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NickPhura NickPhura merged commit 2490988 into dev May 31, 2024
20 of 36 checks passed
@NickPhura NickPhura deleted the np_techdebt_pipeline_2 branch May 31, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants