#274 - Merge release v2.2.0 to v2.3.0 #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [ ] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
**Technical Details** - [x] Ensure the file name is escaped while downloading to prevent the issue with the comma and some other potential characters. - [x] Add an E2E test with some scenarios to test different characters. - [x] This should be added to v2.2 branch. Demo: Able to Download File with Comma  
- Added the [openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer) to all action steps that require some OC iteration. - Using the [default options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs). - Using the fixed version "4". The current version printed is `OC CLI Version: Client Version: 4.17.9`. Please note, for steps printing the `OC version`, the new action was added before the print step. For steps not printing the `OC version`, the new step was added right before the "Log in to OpenShift". Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
- Added the [openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer) to all action steps that require some OC iteration. - Using the [default options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs). - Using the fixed version "4". The current version printed is `OC CLI Version: Client Version: 4.17.9`. Please note, for steps printing the `OC version`, the new action was added before the print step. For steps not printing the `OC version`, the new step was added right before the "Log in to OpenShift". Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
### As a part of this PR, the following were completed:
- Ensured that the sequence numbers in PT and FT eCert file header is
incremented as a lifetime value.
- Started the next PROD sequence number at **7 for PT eCerts** and **FT
eCerts are left as is (set to start at 1).** For this, added the
following SQL to the Release 2.2 notes:
```sql
INSERT INTO sims.sequence_controls
(sequence_name, sequence_number)
VALUES ('ECERT_PT_SENT_FILE', 6), ('ECERT_FT_SENT_FILE', 0);
```
**Screenshots:**
<img width="1920" alt="image"
src="https://github.com/user-attachments/assets/d7c854ae-a4f0-4163-9717-acd3e2e3c997"
/>
---------------------------------------------
<img width="1919" alt="image"
src="https://github.com/user-attachments/assets/287fdbd3-e7f7-4a41-8a1b-06b9c20b9c16"
/>
- Resolved conflicts in file e-cert-file-handler.ts
sh16011993
added
the
Branch Sync-up
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, release v2.2.0 is merged to v2.3.0