#3965 - Separate Sequencing for FT and PT eCert Numbers

[bidyashish]

Technical

• Append the offering intensity as a prefix following the same done for MSFAA.
• Create the DB migration to rename the current DISBURSEMENT_DOCUMENT_NUMBER to Part Time_DISBURSEMENT_DOCUMENT_NUMBER.
• Upinsert the mentioned values for non-PROD (DEV/TEST/Staging).

Db Migrations: Run

Db Migrations:: Demo

Db Migrations: Revert

Up Insert: non-PROD (DEV/TEST/Staging).

-- Part Time Document Number Sequence Control
UPDATE sims.sequence_controls
SET sequence_number = 200000
WHERE sequence_name = 'Part Time_DISBURSEMENT_DOCUMENT_NUMBER';

-- Full Time Document Number Sequence Control
UPDATE sims.sequence_controls
SET sequence_number = 12000000
WHERE sequence_name = 'Full Time_DISBURSEMENT_DOCUMENT_NUMBER';

Extra E2E Test sources/packages/backend/apps/api/src/route-controllers/confirmation-of-enrollment/_tests_/e2e/confirmation-of-enrollment.institutions.confirmEnrollment.e2e-spec.ts

[lewischen-aot]

I think we can also assert that the sequence control record created by the COE operation has the correct sequence name, which is "Part Time_DISBURSEMENT_DOCUMENT_NUMBER", and the sequence number is the document number for the disbursement schedule record of the application.

[bidyashish]

Added the sequence Control Assert test.

[lewischen-aot]

Not a blocker. As a recommendation, since the PR is to separate FT and PT sequence names, it would be nice to include a test case for FT application to verify the sequence name as "Full Time_DISBURSEMENT_DOCUMENT_NUMBER".

[bidyashish]

Added the sequence Control Assert test for Full Time.

[lewischen-aot]

Nice work for getting the gist of the story in this PR 👍 Please take a look at some minor comments.

[andrewsignori-aot]

Nice work, please take a look at the comments.

[andrewsignori-aot]

Thanks for making the changes, only minor changes left.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	22.22% ( 3781 / 17020 )
Methods:	10.19% ( 219 / 2150 )
Lines:	25.65% ( 3276 / 12770 )
Branches:	13.62% ( 286 / 2100 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	65.59% ( 589 / 898 )
Methods:	59.63% ( 65 / 109 )
Lines:	68.72% ( 468 / 681 )
Branches:	51.85% ( 56 / 108 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	86.14% ( 1249 / 1450 )
Methods:	82.42% ( 136 / 165 )
Lines:	88.51% ( 1032 / 1166 )
Branches:	68.07% ( 81 / 119 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	67.4% ( 5922 / 8787 )
Methods:	65.09% ( 729 / 1120 )
Lines:	71.33% ( 4647 / 6515 )
Branches:	47.4% ( 546 / 1152 )

[andrewsignori-aot]

Thanks for making the changes, nice work, looks good 👍

[lewischen-aot]

PR looks great. Nice work 👍