Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4132 - Update Form IO (Tooltip Fix) #4187

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

lewischen-aot
Copy link
Collaborator

  • Added CSS for tooltips in formio shared css file.

Screenshot of the tooltip before and after fix
image

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3783 / 17024 )
Methods: 10.19% ( 219 / 2149 )
Lines: 25.66% ( 3278 / 12773 )
Branches: 13.61% ( 286 / 2102 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@lewischen-aot lewischen-aot marked this pull request as ready for review December 27, 2024 21:26
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.15% ( 1238 / 1437 )
Methods: 82.32% ( 135 / 164 )
Lines: 88.44% ( 1025 / 1159 )
Branches: 68.42% ( 78 / 114 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. I do not see a problem proceeding with these fixes right now because having the upgrade done is way more important than some missing icons.
Do you mind creating a tech debt to further investigate why the icons styles are being overwritten? There seems an issue between bi vs fa icons. It may be an issue with the new form.io version or something that we should look at and have configured.
Looks good 👍

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants