Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - Part 3 #4182

Merged
merged 6 commits into from
Dec 30, 2024
Merged

#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - Part 3 #4182

merged 6 commits into from
Dec 30, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Dec 26, 2024 •
edited
Loading

  • Changed logic to:
    • Not consider part-time SFAS cancelled applications for program year totals;
    • Not consider part-time application date overlap and;
    • Ignore full-time and part-time applications in the MSFAA number process.
  • Added E2E tests;

@andrepestana-aot andrepestana-aot self-assigned this Dec 27, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review December 28, 2024 00:10
@dheepak-aot
Copy link
Collaborator

Great Work. Only minor comments.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.2% ( 3783 / 17038 )
Methods: 10.19% ( 219 / 2150 )
Lines: 25.65% ( 3278 / 12781 )
Branches: 13.57% ( 286 / 2107 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

guru-aot
guru-aot reviewed Dec 30, 2024
View reviewed changes
sources/packages/backend/libs/services/src/sfas/sfas-part-time-application.service.ts
@@ -38,7 +38,10 @@ export class SFASPartTimeApplicationsService extends DataModelService<SFASPartTi
.createQueryBuilder("sfasPTApplication")
.select(["sfasPTApplication.id"])
.innerJoin("sfasPTApplication.individual", "sfasPTstudent")
.where("lower(sfasPTstudent.lastName) = lower(:lastName)", { lastName })
.where("sfasPTApplication.applicationCancelDate IS NULL")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

guru-aot
guru-aot approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrepestana-aot

dheepak-aot
dheepak-aot approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. Looks good 👍

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit b35b5f1 Dec 30, 2024
21 checks passed
@andrepestana-aot andrepestana-aot deleted the 4133_sfas_to_sims_pt_app_cancellation_date_msfaa_ftpt_3 branch December 30, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
Camunda Workers E2E/Unit tests SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @dheepak-aot @guru-aot