Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - part 2 #4178

Merged
merged 2 commits into from
Dec 26, 2024
Merged

#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - part 2 #4178

merged 2 commits into from
Dec 26, 2024
+43 −7

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Dec 24, 2024 •
edited
Loading

Integration and test part.

  • Added new column to model;
  • Added application cancel date;
  • Added assert to integration test;

@andrepestana-aot andrepestana-aot self-assigned this Dec 24, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.15% ( 3785 / 17090 )
Methods: 10.13% ( 219 / 2162 )
Lines: 25.57% ( 3280 / 12829 )
Branches: 13.63% ( 286 / 2099 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.95% ( 1266 / 1508 )
Methods: 74.01% ( 131 / 177 )
Lines: 86.72% ( 1058 / 1220 )
Branches: 69.37% ( 77 / 111 )

@andrepestana-aot andrepestana-aot marked this pull request as ready for review December 26, 2024 18:50
@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@dheepak-aot dheepak-aot self-requested a review December 26, 2024 19:09
dheepak-aot
dheepak-aot reviewed Dec 26, 2024
View reviewed changes
...rs/src/processors/schedulers/sfas-integration/_tests_/sfas-integration.scheduler.e2e-spec.ts
bcagAward: 27,
cslpAward: 800,
programYearId: 20232024,
applicationCancelDate: "2024-02-01",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dheepak-aot
dheepak-aot approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @andrepestana-aot. Great Job.

guru-aot
guru-aot approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrepestana-aot

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 454f69b Dec 26, 2024
21 checks passed
@andrepestana-aot andrepestana-aot deleted the 4133_sfas_to_sims_pt_app_cancellation_date_msfaa_ftpt_2 branch December 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
E2E/Unit tests Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @dheepak-aot @guru-aot