#4079 - Queue Monitoring - Schedulers Refactor (Part 6) #4177
Conversation
| @@ -86,7 +90,7 @@ export class ATBCIntegrationProcessingService { | |||
| this.logger.log( | |||
There was a problem hiding this comment.
Can we remove this logger?
There was a problem hiding this comment.
Removed.
| processSummary.info( | ||
| `Total notifications processed ${processNotificationResponse.notificationsProcessed}.`, | ||
| ); | ||
| processSummary.info( | ||
| `Total notifications successfully processed ${processNotificationResponse.notificationsSuccessfullyProcessed}.`, | ||
| ); |
There was a problem hiding this comment.
Minor. As this is a result, it can be part of return. As there is no E2E tests for this scheduler, there won't be further impacts in changing the return.
There was a problem hiding this comment.
Added the result to the summary and result also.
| if ( | ||
| processNotificationResponse.notificationsProcessed !== | ||
| processNotificationResponse.notificationsSuccessfullyProcessed | ||
| ) { | ||
| processSummary.warn( | ||
| "Not all pending notifications were successfully processed.", | ||
| ); | ||
| } |
| "Found 0 application changes.", | ||
| `Application changes report with file name ${expectedFileName} has been uploaded successfully.`, |
| // Mock the current date. | ||
| const now = new Date(); | ||
| MockDate.set(now); | ||
| expectedFileName = `DPBC.EDU.APPCHANGES.${formatFileNameDate(now)}.csv`; |
There was a problem hiding this comment.
Great Job. Only 2 minor comments.
Recording our conversation regarding moving the code to add the message to queue inside the transaction here. workflow-enqueuer.service.ts
It is outside the scope of the PR.
| expect( | ||
| mockedJob.containLogMessages([ | ||
| "Retrieving all application changes which were not reported already.", |
There was a problem hiding this comment.
Very minor: maybe it could be rephrased to: "Retrieving all application changes that have not yet been reported."
There was a problem hiding this comment.
Updated as suggested.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Refactored the below schedulers and associated E2E tests.