#4015 - FT program year total contribution limits #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guru-aot
changed the title
guru-aot
changed the title
guru-aot
added
Camunda Workers
Camunda Worflow
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts
Outdated
Show resolved
Hide resolved
...s/backend/libs/services/src/students-assessments/assessment-sequential-processing.service.ts
Outdated
Show resolved
Hide resolved
...rs/assessment/_tests_/e2e/assessment.controller-verifyAssessmentCalculationOrder.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/services/src/students-assessments/student-assessment.model.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/workflow/src/workflow-definitions/assessment-gateway.bpmn
Outdated
Show resolved
Hide resolved
Comment on lines
+977
to
+980
| programYearTotalFederalFSC: 0, | ||
| programYearTotalProvincialFSC: 0, | ||
| programYearTotalScholarshipsBursaries: 0, | ||
| programYearTotalSpouseContributionWeeks: 0, |
There was a problem hiding this comment.
Same question for a later comment, should we return 0 when values are not defined?
If the SUM results in 0 I do not see a problem, but having 0 as a fallback for an undefined value, do we need that?
There was a problem hiding this comment.
we are not doing any calculation still in the workflow, i thought it would be better to return 0 than null, as the variable name states "programYearTotal" either it can be 0 or some numeric value.
There was a problem hiding this comment.
My point is the variable programYearTotal* will not be even there if not present.
| !!applicationNumbers?.length; | ||
| const [awardTotals, contributionTotals] = await Promise.all([ | ||
| // Get the program year awards totals for part-time and full-time. | ||
| await this.getProgramYearPreviousAwardsTotals( |
There was a problem hiding this comment.
We don't need to await here.
| /** | ||
| * Full-time program year contribution and its totals. | ||
| */ | ||
| export interface programYearContributionTotal { |
There was a problem hiding this comment.
programYearContributionTotal should start with a capital letter.
added 2 commits
December 20, 2024 16:54
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts
Outdated
Show resolved
Hide resolved
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
andrewsignori-aot
approved these changes
Dec 21, 2024
E2E SIMS API Coverage Report
|
andrepestana-aot
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR separation is not done, as the workflow change was very minor and it can be accommodated in a single PR.