Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4079 - Queue Monitoring - Schedulers Refactor - (MSFAA) #4141

Merged
merged 4 commits into from
Dec 20, 2024
Merged

#4079 - Queue Monitoring - Schedulers Refactor - (MSFAA) #4141

merged 4 commits into from
Dec 20, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 18, 2024 •
edited
Loading

  • Refactored MSFAA-related schedulers and adjusted E2E tests.
    • full-time-msfaa-integration
    • part-time-msfaa-process-integration
    • part-time-msfaa-process-response-integration
    • full-time-msfaa-process-response-integration
  • Additional Refactor
    • As agreed in the previous PR, added extra logs to the BaseQueue start and end.

@andrewsignori-aot andrewsignori-aot self-assigned this Dec 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.11% ( 3781 / 17098 )
Methods: 10.12% ( 219 / 2165 )
Lines: 25.51% ( 3276 / 12843 )
Branches: 13.68% ( 286 / 2090 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 82.7% ( 1291 / 1561 )
Methods: 70.05% ( 131 / 187 )
Lines: 85.67% ( 1082 / 1263 )
Branches: 70.27% ( 78 / 111 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review December 19, 2024 21:22
@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@dheepak-aot dheepak-aot self-requested a review December 20, 2024 00:53
dheepak-aot
dheepak-aot reviewed Dec 20, 2024
View reviewed changes
sources/packages/backend/apps/queue-consumers/src/processors/schedulers/base-queue.ts
// Log the start of the process for the summary and logger.
const startLogMessage = `Processing queue ${job.queue.name}, job ID ${job.id}.`;
processSummary.info(startLogMessage);
this.logger.log(startLogMessage);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dheepak-aot
dheepak-aot approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with MSFAA schedulers. Looks good 👍

guru-aot
guru-aot reviewed Dec 20, 2024
View reviewed changes
...libs/integrations/src/esdc-integration/msfaa-integration/msfaa-request.processing.service.ts
@@ -32,15 +36,19 @@ export class MSFAARequestProcessingService extends ESDCFileHandler {
* 4. Create the request filename with the file path for the MSFAA Request sent File.
* 5. Upload the content to the zoneB SFTP server.
* 6. Update the MSFAA records, that are sent in the request sent file.
* @param fileCode File code applicable for Part-Time or Full-Time.
* @param fileCode file code applicable for Part-Time or Full-Time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

guru-aot
guru-aot approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

@andrewsignori-aot andrewsignori-aot added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 31d6777 Dec 20, 2024
21 checks passed
@andrewsignori-aot andrewsignori-aot deleted the feature/#4076-schedulers-refactor-part-4 branch December 24, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Queue Consumers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewsignori-aot @dheepak-aot @guru-aot