Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4128 - Persist uploaded documents and exception triggering for dependants with disability #4140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#4128 - Persist uploaded documents and exception triggering for dependants with disability #4140

wants to merge 1 commit into from
+41 −43

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Dec 18, 2024 •
edited
Loading

  • Removed key "Clear value when hidden" for file component "pdDependentUpload" for program years
    • 2022-23
    • 2023-24
    • 2024-25
  • Ensured that the file will reappear when reactivated with future edits.
  • Ensured that the declared on taxes exception is triggered when file is required but not provided for a dependant.

Screenshot for when the declared on taxes exception is triggered
image

Screenshot for files successfully submitted and reappeared with future edits
image

Screenshot of the dependant component with files on ministry portal
image

@lewischen-aot lewischen-aot added User Story Student Student Features Ministry Ministry Features Form.io Form IO definitions changed. Business Items under Business Consideration labels Dec 18, 2024
@lewischen-aot lewischen-aot self-assigned this Dec 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.05% ( 3785 / 17168 )
Methods: 10.05% ( 219 / 2180 )
Lines: 25.43% ( 3280 / 12898 )
Branches: 13.68% ( 286 / 2090 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 81.15% ( 1309 / 1613 )
Methods: 66.34% ( 134 / 202 )
Lines: 84.38% ( 1097 / 1300 )
Branches: 70.27% ( 78 / 111 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@lewischen-aot lewischen-aot marked this pull request as ready for review December 18, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepestana-aot andrepestana-aot andrepestana-aot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lewischen-aot lewischen-aot

Labels
Business Items under Business Consideration Form.io Form IO definitions changed. Ministry Ministry Features Student Student Features User Story
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewischen-aot @andrepestana-aot