#4019 - Virus Scan False Positives #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
reviewed
Dec 17, 2024
| @@ -562,7 +562,7 @@ MaxRecursion 10 | |||
| # Note: disabling this limit or setting it too high may result in severe damage | |||
| # to the system. | |||
| # Default: 10000 | |||
| MaxFiles 100 | |||
| MaxFiles 10000 | |||
There was a problem hiding this comment.
As it is set to default value please comment this line leaving the default value to be in effect.
There was a problem hiding this comment.
Thanks @dheepak-aot
Default value is commented.
dheepak-aot
reviewed
Dec 17, 2024
sources/packages/clam-av/clamd.conf
Outdated
| @@ -562,7 +562,7 @@ MaxRecursion 10 | |||
| # Note: disabling this limit or setting it too high may result in severe damage | |||
| # to the system. | |||
| # Default: 10000 | |||
| MaxFiles 100 | |||
| MaxFiles 10000 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @dheepak-aot
Default value is commented.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
approved these changes
Dec 17, 2024
E2E SIMS API Coverage Report
|
andrepestana-aot
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Notes
MaxFiles 100 was causing issue with file being not scanned and using ClamAV virus Database bank to not scan file.
MaxFiles in ClamAV's configuration refers to the maximum number of files to be scanned within an archive, document, or any other container file. Here's a detailed explanation: For example: If scanning a ZIP file containing 15,000 files with MaxFiles 10000: Only the first 10,000 files will be scanned The remaining 5,000 files will be skipped If AlertExceedsMax is enabled, it will trigger a "Heuristics.Limits.Exceeded.MaxFiles" alertUpdate Clam AV Docker from BCGOV Repo
Link: https://github.com/bcgov/common-hosted-clamav-service/pkgs/container/clamav-unprivileged
Demo: Manual test in Dev using Config update.
