Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3268 - crunchy db GitHub action #3614

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Aug 7, 2024

Update Github action of crunchy DB installation for a minor error.

@guru-aot guru-aot changed the title #3268 crunchy db GitHub action #3268 - crunchy db GitHub action Aug 7, 2024
@guru-aot guru-aot self-assigned this Aug 7, 2024
@dheepak-aot dheepak-aot self-requested a review August 7, 2024 17:26
Copy link

sonarqubecloud bot commented Aug 7, 2024

Copy link

github-actions bot commented Aug 7, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.04% ( 3383 / 15350 )
Methods: 10.1% ( 195 / 1931 )
Lines: 25.66% ( 2975 / 11592 )
Branches: 11.66% ( 213 / 1827 )

Copy link

github-actions bot commented Aug 7, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.5% ( 506 / 865 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.1% ( 408 / 657 )
Branches: 41.35% ( 43 / 104 )

@@ -23,9 +23,9 @@ upgrade: helm-dep
echo "Error: RESTORE_TARGET is required when RESTORE_ENABLED is true."; \
exit 1; \
fi; \
helm upgrade --install ${NAME} . -n ${NAMESPACE} --set restore.enabled=true --set restore.options.target="${RESTORE_TARGET}" -f values.yaml; \
helm upgrade --install ${NAME} . -n ${NAMESPACE} --set restore.enabled=${RESTORE_ENABLED} --set restore.options.target="${RESTORE_TARGET}" -f values.yaml; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change.

Copy link

github-actions bot commented Aug 7, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 81.98% ( 928 / 1132 )
Methods: 83.19% ( 99 / 119 )
Lines: 83.82% ( 798 / 952 )
Branches: 50.82% ( 31 / 61 )

Copy link

github-actions bot commented Aug 7, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 64.03% ( 5230 / 8168 )
Methods: 60.73% ( 631 / 1039 )
Lines: 68.3% ( 4144 / 6067 )
Branches: 42.84% ( 455 / 1062 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@guru-aot guru-aot added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 52fb88c Aug 7, 2024
21 checks passed
@guru-aot guru-aot deleted the #3268_Crunchy_DB_Github_Action branch August 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants