Skip to content

Commit

Permalink
#3827 - Student: Sole custody dependant question change (#4091)
Browse files Browse the repository at this point in the history
- Made these changes for the 25-26 program year application form
- Moved "Are any of the dependants listed above supported by you
financially but not under your sole custody?" question to the "Add
Dependants" box.
- Revised the question to: "Is the dependant listed above supported by
you financially but not under your sole custody?"
- Removed the key "Clean value when hidden" (`"clearOnHide": false`) for
file components `pdDependentUpload` and `dependantCustodyFileUpload` to
retain file data in the data column in each application record.
- Hooked the file component `pdDependentUpload` to `declaredOnTaxes`
condition.
- This question is included for each individual dependant added.
- Made sure that each individual dependant that has this exception
selected has their own exception line on the ministry UI.
- Applied changes to FT/PT

#### Note
Please note that the key `supportnocustodyDependants` is being used in
[Data Inventory Report SQL
script](https://github.com/bcgov/SIMS/blob/abd72bc8f549d387e0916ad14796e70e9d846ab0/sources/packages/backend/apps/db-migrations/src/sql/Reports/Create-data-inventory-report.sql#L179C37-L179C63).
The current approach moves the key `supportnocustodyDependants` from
`applications.data` to `applications.dependants` for applications
**2025-2026 only**, so the Data Inventory Report CSV file will lose the
data for column "Has dependants without sole custody flag"
(`supportnocustodyDependants`) for applications 2025-2026. To retain
this data, a simple workaround solution is available in the [workaround
commit](1444a25),
where the key `supportnocustodyDependants` is still accessible in
`applications.data` and its value is calculated based on whether any
dependant is without sole custody or not inside the dependants array. As
discussed in the standup, the workaround is not recommended, so it
mentioned here to as a reference to keep developers updated.

Screenshot on the student portal

![image](https://github.com/user-attachments/assets/db6a14cf-b504-43b6-8d97-849905c61f34)

Screenshot on the ministry portal

![image](https://github.com/user-attachments/assets/fa0988fc-4ad8-44ec-ba42-87e99db7e069)

Screenshot of the exception trigger when files are required

![image](https://github.com/user-attachments/assets/c170cf95-e918-4f4d-a7fd-680827e2a117)
  • Loading branch information
lewischen-aot authored Dec 16, 2024
1 parent abef161 commit af0d8ff
Showing 1 changed file with 862 additions and 860 deletions.
Loading

0 comments on commit af0d8ff

Please sign in to comment.