-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSP-6945 : Access to PIMS Overview (Help File) - Header #3501
Merged
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
52ab9ab
PSP-6945 : Access to PIMS Overview (Help File) - Header
ae2bc8f
Merge branch 'dev' into psp-6945
9725422
- test update
3a93ab0
Merge branch 'dev' into psp-6945
d068525
PSP-6945 : Access to PIMS Overview (Help File) - Header
aca7a8c
- test update
8a7a149
PSP-6786 : Access to PIMS Overview (Help File) - Modal
b185b42
Merge branch 'psp-6945' of https://github.com/eddherrera/PSP into psp…
1351777
- test updates
11b0f87
- updates to open sharepoint
1d3aec6
Merge branch 'dev' into psp-6945
efc891d
- test updates
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
56 changes: 0 additions & 56 deletions
56
source/frontend/src/features/help/components/HelpBox.test.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,12 @@ | ||
import { act, render, screen, waitFor } from '@testing-library/react'; | ||
|
||
import { TicketTypes } from '../constants/HelpText'; | ||
import HelpSubmitBox from './HelpSubmitBox'; | ||
|
||
const renderHelpBox = (ticketType: TicketTypes) => | ||
const renderHelpBox = () => | ||
render( | ||
<HelpSubmitBox | ||
activeTicketType={ticketType} | ||
user="Test User" | ||
email="[email protected]" | ||
setActiveTicketType={jest.fn(x => x)} | ||
setMailto={jest.fn()} | ||
page="Landing Page" | ||
/>, | ||
|
@@ -18,39 +15,18 @@ const renderHelpBox = (ticketType: TicketTypes) => | |
describe('Help Box tests', () => { | ||
it('renders properly', async () => { | ||
await act(async () => { | ||
const { asFragment } = renderHelpBox(TicketTypes.QUESTION); | ||
const { asFragment } = renderHelpBox(); | ||
const fragment = await waitFor(() => asFragment()); | ||
|
||
expect(fragment).toMatchSnapshot(); | ||
}); | ||
}); | ||
|
||
it('contains question field and option when question selected', async () => { | ||
it('displays appropriate fields', async () => { | ||
await act(async () => { | ||
renderHelpBox(TicketTypes.QUESTION); | ||
renderHelpBox(); | ||
}); | ||
|
||
const question = await waitFor(() => screen.getAllByText('Question')); | ||
expect(question).toHaveLength(2); | ||
}); | ||
|
||
it('displays appropriate fields when switching to bug type', async () => { | ||
await act(async () => { | ||
renderHelpBox(TicketTypes.BUG); | ||
}); | ||
const reproduce = await waitFor(() => screen.getByText('Steps to Reproduce')); | ||
const expected = await waitFor(() => screen.getByText('Expected Result')); | ||
const result = await waitFor(() => screen.getByText('Actual Result')); | ||
expect(reproduce).toBeInTheDocument(); | ||
expect(expected).toBeInTheDocument(); | ||
expect(result).toBeInTheDocument(); | ||
}); | ||
|
||
it('displays appropriate fields when switching to feature request ticket type', async () => { | ||
await act(async () => { | ||
renderHelpBox(TicketTypes.FEATURE_REQUEST); | ||
}); | ||
const desc = await waitFor(() => screen.getByText('Description')); | ||
const desc = await waitFor(() => screen.getByText('Description:')); | ||
expect(desc).toBeInTheDocument(); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed this, but I assume this will be replaced with the actual tenant/openshift configmap based url so that we can modify this after deployment without needing a code change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated