PSP-6945 : Access to PIMS Overview (Help File) - Header #3501
Conversation
eddherrera
commented
Oct 4, 2023
eddherrera
commented
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3501 +/- ##
==========================================
+ Coverage 66.19% 75.28% +9.08%
==========================================
Files 464 876 +412
Lines 14195 17760 +3565
Branches 1019 4986 +3967
==========================================
+ Hits 9397 13370 +3973
+ Misses 4551 4390 -161
+ Partials 247 0 -247
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eddherrera
requested review from
devinleighsmith,
asanchezr,
FuriousLlama,
stairaku,
PryancaJSharma and
buddy326
as code owners
|
Hey Eduardo, I think you may have missed the mockup for psp-6945:
|
| </p> | ||
| <LinkStyled | ||
| target="_blank" | ||
| href="https://sp.th.gov.bc.ca/sites/PropertiesServices/Project%20Management/03.%20Execution%20and%20Control/PIMS%20Training" |
There was a problem hiding this comment.
I think we discussed this, but I assume this will be replaced with the actual tenant/openshift configmap based url so that we can modify this after deployment without needing a code change?
| activeTicketType={activeTicketType} | ||
| setActiveTicketType={setActiveTicketType} | ||
| page={helpPage?.name ?? location.pathname} | ||
| page={location.pathname} |
There was a problem hiding this comment.
do we still need this? I feel like help is no longer context sensitive.
There was a problem hiding this comment.
I am passing the path as part of the email subject. should I remove it alltogether?
|
@eddherrera submitting the help form seems bugged, subject and body both coming through as undefined now. |
devinleighsmith
force-pushed
the
psp-6945
branch
from
3a93ab0 to
aca7a8c
Compare
|
✅ No secrets were detected in the code. |
…-6945 # Conflicts: # source/frontend/src/features/help/components/HelpModal.tsx
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
@eddherrera we have another story to update modal styling but not one to update header styling. I'll leave it up to you if you'd rather
|
|
@eddherrera also, I'm still seeing undefined as the subject and body when clicking yes on the help modal, that needs to be fixed. |
Added with the last commit |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
