-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to lint react-app #2013
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bd1722f
Add workflow to lint react-app
TaylorFries 13c4a81
match file names
TaylorFries 5dcf58f
include duplicate enum check
TaylorFries 3ff6f9d
Update .github/workflows/react-app-lint.yml
TaylorFries 4d1243d
Clean last line
dbarkowsky 483f2a9
Merge branch 'main' into PIMS-621-react-app-linting-workflow
dbarkowsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: React App Linting Check | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize] | ||
branches: [main] | ||
paths: | ||
- 'react-app/**' | ||
- '.github/workflows/react-app-lint.yml' | ||
workflow_dispatch: | ||
|
||
jobs: | ||
lint-api: | ||
name: Lint React App | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
# Could optimize this by only installing necessary dependencies | ||
- name: Install Dependencies | ||
working-directory: ./react-app | ||
run: npm i --only=dev | ||
|
||
- name: Run ESLint | ||
working-directory: ./react-app | ||
run: npm run lint | ||
|
||
- name: Run Prettier | ||
working-directory: ./react-app | ||
run: npm run check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always assumed this worked, but now I see this output:
Doesn't hurt to have it in, but maybe it's not doing what we thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some searching it seems like this flag stopped working in 2020, any updated command seems to not replicate what this did.