Add workflow to lint react-app #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaylorFries
requested review from
LawrenceLau2020,
Sharala-Perumal,
dbarkowsky and
GrahamS-Quartech
as code owners
dbarkowsky
reviewed
Jan 4, 2024
| # Could optimize this by only installing necessary dependencies | ||
| - name: Install Dependencies | ||
| working-directory: ./react-app | ||
| run: npm i --only=dev |
There was a problem hiding this comment.
I always assumed this worked, but now I see this output:
Doesn't hurt to have it in, but maybe it's not doing what we thought.
There was a problem hiding this comment.
After some searching it seems like this flag stopped working in 2020, any updated command seems to not replicate what this did.
Co-authored-by: Dylan Barkowsky <[email protected]>
dbarkowsky
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
PIMS-621:
Add linting workflow for react-app folder
🔰 Checklist