Vue 3

.github/pull_request_template.md

@@ -1,8 +1,14 @@
 ### Please check if the PR fulfills these requirements:
 
 - [ ] After these changes, the app was run and still works as expected
-- [ ] Unit tests for these changes were added (if applicable)
+- [ ] Tests for these changes were added (if applicable)
+- [ ] `npm audit` was checked, applicable vulnerabilities were updated
+- [ ] `npm run build` passes
+- [ ] `npm run lint` has no unexpected errors
+- [ ] `npm run format` was run on changed files
 - [ ] All existing unit tests were run and still pass
+- [ ] End-to-end tests were run and still pass in Chrome, Firefox, and Edge without unexpected console errors (`npm run test:e2e`)
+
 
 ### Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
 

jha/.eslintrc.js

@@ -1,15 +1,13 @@
 module.exports = {
   root: true,
   env: {
-    node: true
+    node: true,
+    es2022: true,
   },
   'extends': [
     'plugin:vue/essential',
     'eslint:recommended'
-  ],
-  parserOptions: {
-    parser: "@babel/eslint-parser",
-  },
+  ],  
   rules: {
     'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
     'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off'

jha/README.md

@@ -32,9 +32,17 @@ npm run test:e2e
 ```
 npm run lint
 ```
+This project uses ESLint for linting.
+
+```sh
+npm run format
+```
+
+This project uses Prettier for code formatting.
 
 ### Dev Settings
 Adjust the values in `src/settings.js` to more easily walk through the application during development
 
-### Customize configuration
-See [Configuration Reference](https://cli.vuejs.org/config/).
+### Other important notes
+
+This library requires a minimum of node 18 for compatibility with Vite and other dependencies, and a minimum of node 22 for compatibility with the pdf-js package used by the common library dependency.

jha/cypress.config.js

@@ -0,0 +1,13 @@
+import { defineConfig } from "cypress";
+import vitePreprocessor from 'cypress-vite'
+
+export default defineConfig({
+  e2e: {
+    baseUrl: 'http://172.25.129.209:5173/ahdc/',
+    experimentalRunAllSpecs: true,
+    testIsolation: false, //to prevent Cypress errors
+    setupNodeEvents(on) {
+      on('file:preprocessor', vitePreprocessor())
+    },
+  },
+});

jha/tests/e2e/specs/FPC.js → jha/cypress/e2e/FPC.cy.js

@@ -1,5 +1,6 @@
 import { generateRequestObject } from '../fixtures/fpcStandaloneRequest';
-import { removeUniqueFields } from '../helpers';
+import { removeUniqueFields } from '../support/helpers';
+import envData from '../fixtures/env-data.js'
 
 describe('FPC only application', () => {
   const options = { includeFPC: true }
@@ -12,15 +13,26 @@ describe('FPC only application', () => {
   });
 
   it('Accepts valid information for the spouse page', () => {
-    cy.fillSpousePage(options)
+    if (envData.skipSpouse) {
+      cy.skipSpousePage();
+    } else {
+      cy.fillSpousePage(options);
+    }    
   });
 
   it('Accepts valid information for the child page', () => {
-    cy.fillChildPage(options)
+    if (envData.skipChild) {
+      cy.skipChildPage();
+    } else {
+      cy.fillChildPage(options)      
+    } 
   })
 
   it('Accepts valid information for the FPC info page', () => {
     cy.fillFPCInfoPage()
+    cy.location().should((loc) => {
+      expect(loc.pathname).to.eq("/ahdc/contact-info");
+    });
   })
 
   it('Accepts valid information for the contact info page', () => {
@@ -35,14 +47,17 @@ describe('FPC only application', () => {
   it('Submits with the expected payload', () => {
     cy.fillConsent(options);
     cy.submitApplication();
-    cy.wait('@submitApplication')
+    if (envData.enableIntercepts) {
+      //in the local environment, we want to check that the intercepted API response matches what it should
+      cy.wait('@submitApplication')
       .then(interception => {
         expect(removeUniqueFields(interception.request.body)).to.deep.equal(removeUniqueFields(generateRequestObject()))
       });
+    }
   });
 
   it('Redirects user to confirmation page when successful', () => {
-    cy.url().should('include', 'submission');
+    cy.url({ timeout: 20000 }).should('include', 'submission');
     cy.contains('Confirmation of submission')
   });
 });

jha/tests/e2e/specs/MSP.js → jha/cypress/e2e/MSP.cy.js

@@ -1,11 +1,12 @@
 import { generateRequestObject } from '../fixtures/mspStandaloneRequest.js';
-import { removeUniqueFields } from '../helpers';
+import { removeUniqueFields } from '../support/helpers';
+import envData from '../fixtures/env-data.js'
 
 describe('MSP only application', () => {
   const options = {includeMSP: true}
   it('Fills eligibility questionnaire', () => {
     cy.fillEligibilityQuestionnaire(options)
-  })
+  });
 
   it('Accepts valid information for the personal-info page', () => {
     cy.fillPersonalInfoPage(options)
@@ -17,29 +18,31 @@ describe('MSP only application', () => {
 
   it('Accepts valid information for the child page', () => {
     cy.fillChildPage(options)
-  })
+  });
 
   it('Accepts valid information for the contact info page', () => {
     cy.fillResidentialAddress()
-  })
+  });
 
   it('Displays the phone number with contact information', () => {
     cy.contains('(555) 555-5555')
     cy.continue();
-  })
+  });
 
   it('submits form with expected payload', () => {
     cy.fillConsent(options)
     cy.submitApplication()
-    cy.wait('@submitApplication')
+    if (envData.enableIntercepts) {
+      //in the local environment, we want to check that the intercepted API response matches what it should
+      cy.wait('@submitApplication')
       .then(interception => {
         expect(removeUniqueFields(interception.request.body)).to.deep.equal(removeUniqueFields(generateRequestObject()))
       })
+    }    
   });
 
   it('Redirects user to confirmation page when successful', () => {
-    cy.url().should('include', 'submission');
+    cy.url({ timeout: 20000 }).should('include', 'submission');
     cy.contains('Confirmation of submission')
   });
-
 });

jha/tests/e2e/specs/SB.js → jha/cypress/e2e/SB.cy.js

@@ -1,11 +1,12 @@
 import { generateRequestObject } from '../fixtures/sbStandaloneRequest.js';
-import { removeUniqueFields } from '../helpers';
+import { removeUniqueFields } from '../support/helpers';
+import envData from '../fixtures/env-data.js'
 
 describe('SB only application', () => {
   const options = {includeSB: true}
   it('Fills eligibility questionnaire', () => {
     cy.fillEligibilityQuestionnaire(options)
-  })
+  });
 
   it('Accepts valid information for the personal-info page', () => {
     cy.fillPersonalInfoPage(options)
@@ -21,6 +22,9 @@ describe('SB only application', () => {
 
   it('Accepts valid information for the documents page', () => {
     cy.fillDocumentsPage()
+    cy.location().should((loc) => {
+      expect(loc.pathname).to.eq("/ahdc/contact-info");
+    });
   });
 
   it('Accepts valid information for the contact info page', () => {
@@ -30,19 +34,22 @@ describe('SB only application', () => {
   it('Displays the phone number with contact information', () => {
     cy.contains('(555) 555-5555')
     cy.continue();
-  })
+  });
 
   it('submits form with expected payload', () => {
     cy.fillConsent(options)
     cy.submitApplication()
-    cy.wait('@submitApplication')
+    if (envData.enableIntercepts) {
+      //in the local environment, we want to check that the intercepted API response matches what it should
+      cy.wait('@submitApplication')
       .then(interception => {
         expect(removeUniqueFields(interception.request.body)).to.deep.equal(removeUniqueFields(generateRequestObject()))
       })
+    }    
   });
 
   it('Redirects user to confirmation page when successful', () => {
-    cy.url().should('include', 'submission');
+    cy.url({ timeout: 20000 }).should('include', 'submission');
     cy.contains('Confirmation of submission')
   });
 });

jha/tests/e2e/specs/fullApplication.js → jha/cypress/e2e/fullApplication.cy.js

@@ -1,11 +1,12 @@
 import { generateRequestObject } from '../fixtures/fullApplication.js';
-import { removeUniqueFields } from '../helpers';
+import { removeUniqueFields } from '../support/helpers';
+import envData from '../fixtures/env-data.js'
 
 describe('Full application for MSP FPC and SB', () => {
   const options = {includeMSP: true, includeFPC: false, includeSB: true}
   it('Fills eligibility questionnaire', () => {
     cy.fillEligibilityQuestionnaire(options)
-  })
+  });
 
   it('Accepts valid information for the personal-info page', () => {
     cy.fillPersonalInfoPage(options)
@@ -29,24 +30,27 @@ describe('Full application for MSP FPC and SB', () => {
 
   it('Accepts valid information for the contact info page', () => {
     cy.fillResidentialAddress()
-  })
+  });
 
   it('Displays the phone number with contact information', () => {
     cy.contains('(555) 555-5555')
     cy.continue();
-  })
+  });
 
   it('submits form with expected payload', () => {
     cy.fillConsent(options)
     cy.submitApplication()
-    cy.wait('@submitApplication')
+    //in the local environment, we want to check that the intercepted API response matches what it should
+    if (envData.enableIntercepts) {
+      cy.wait('@submitApplication')
       .then(interception => {
         expect(removeUniqueFields(interception.request.body)).to.deep.equal(removeUniqueFields(generateRequestObject()))
       })
+    }    
   });
 
   it('Redirects user to confirmation page when successful', () => {
-    cy.url().should('include', 'submission');
+    cy.url({ timeout: 20000 }).should('include', 'submission');
     cy.contains('Confirmation of submission')
   });
 });