Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 #258

Merged
merged 158 commits into from
Sep 10, 2024
Merged

Vue 3 #258

merged 158 commits into from
Sep 10, 2024

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented Jun 3, 2022

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Unit tests for these changes were added (if applicable)
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

chore

Additional Notes:

Updates for vue-3. Note that this is not ready to merge yet, so I am leaving as a draft. Before merging, it will need the common-lib-vue package to be published for vue-3. Also following that, there will need to be a couple of changes to this pull request:

  • The chainWebpack section in vue.config.js can be removed, it is only necessary to make the symlink work for npm link to connect with a local version of common-lib-vue
  • common-lib-vue will need to be added back as a dependency on version 3. Leaving it out made it easier to work with the local link (this is also breaking the build rn).

I left those in for now in case anyone has time to pull this and test locally, it'll be easier to get setup. If you do test locally, just make sure to pull the v3 version of common-lib-vue, build it, run npm link from that repository (root), and npm link common-lib-vue from the jha directory after installing node packages (you may need to re-run the link command if you rerun npm install). Note that there are some cypress integration tests for the main happy paths as well to help out, although it doesn't test all the validators.

SKYLER MCNAMEE EDIT 09/06/2024:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable) (partially done)
  • npm audit was checked, applicable vulnerabilities were updated
  • npm run build passes
  • npm run lint has no unexpected errors
  • npm run format was run on changed files (this was not done due to the quantity of changes that will need to happen. This will need to happen at a later date)
  • All existing unit tests were run and still pass
  • End-to-end tests were run and still pass in Chrome, Firefox, and Edge without unexpected console errors (npm run test:e2e)

jha/tests/unit/helpers/fpc-helpers.spec.js Dismissed Show dismissed Hide dismissed
jha/tests/unit/helpers/fpc-helpers.spec.js Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@cyrilbravo cyrilbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and all checks passed. Approved.

@skylermcnamee-hibc skylermcnamee-hibc merged commit df3afc4 into main Sep 10, 2024
20 checks passed
@skylermcnamee-hibc skylermcnamee-hibc deleted the vue-3 branch September 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants