-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 #258
Merged
Merged
Vue 3 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-vue for consent modal
…ry and bcgov bootstrap theme
cyrilbravo
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and all checks passed. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
chore
Additional Notes:
Updates for vue-3. Note that this is not ready to merge yet, so I am leaving as a draft. Before merging, it will need the common-lib-vue package to be published for vue-3. Also following that, there will need to be a couple of changes to this pull request:
chainWebpack
section in vue.config.js can be removed, it is only necessary to make the symlink work fornpm link
to connect with a local version of common-lib-vueI left those in for now in case anyone has time to pull this and test locally, it'll be easier to get setup. If you do test locally, just make sure to pull the v3 version of
common-lib-vue
, build it, runnpm link
from that repository (root), andnpm link common-lib-vue
from the jha directory after installing node packages (you may need to re-run the link command if you rerunnpm install
). Note that there are some cypress integration tests for the main happy paths as well to help out, although it doesn't test all the validators.SKYLER MCNAMEE EDIT 09/06/2024:
npm audit
was checked, applicable vulnerabilities were updatednpm run build
passesnpm run lint
has no unexpected errorsnpm run format
was run on changed files (this was not done due to the quantity of changes that will need to happen. This will need to happen at a later date)npm run test:e2e
)