Wsteam1 cta refactor #12097
Draft
Wsteam1 cta refactor #12097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [number]
Overall changes
Possible refactor for #12097
We didn't initially go for this because the styling is fairly different. The existing CTA component uses text-decoration:underline whereas this component uses bottom border.
This is significant because text-decoration:underline ignores SVGs by default but bottom border doesn't. So we have to change the HTML structure so that the SVG doesn't get wrapped in the text element.
There is room for improvement - e.g. if we moved the flex/ centre align styles out of this component and applied these via a className override. And maybe including the chevron here.
Or we could review with UX and see if we can align the A11y behaviours/ styling across the site.
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines