New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSTEAM1-1349: Lite Site CTA #12058

Merged

HarveyPeachey merged 38 commits into latest from WSTEAM1-1349-lite-site-cta

Oct 30, 2024

Contributor

Isabella-Mitchell commented Oct 17, 2024 •

edited by HarveyPeachey

Loading

Resolves JIRA WSTEAM1-1349

Overall changes

Implements Lite/Canonical site CTA to the Gahuza Service. Will show on all .lite pages above Navigation.

Code changes

Adds LiteSiteCTA component
Imports LiteSiteCTA component into Header container to render above Nav
Add Integration & E2E tests for LiteSiteCTA component (limited to Article pages for now)
Updates page metadata title on .lite site.
Adds Gahuza Translations & link supplied from editorial
Adds swarm spreadsheet & A11y links to Storybook metadata

A follow up PR will be needed after soft launch to remove restrictions to Gahuza service & add further E2E tests

Testing

Storybook LTR: https://wsteam1-1349-lite-site-cta--5d28eb3fe163f6002046d6fa.chromatic.com/iframe.html?args=&id=components-litesitecta--component&viewMode=story
Storybook RTL: https://wsteam1-1349-lite-site-cta--5d28eb3fe163f6002046d6fa.chromatic.com/iframe.html?args=&globals=service.service:arabic&id=components-litesitecta--component&viewMode=story
Preview (Active once branch is on preview): https://simorgh.belfrage-preview.test.api.bbc.com/gahuza/articles/cey23zx8wx8o.lite
https://simorgh.belfrage-preview.test.api.bbc.com/gahuza.lite
Local: http://localhost:7080/gahuza.lite. (note the canonical link does not work locally)

Helpful Links

A11y AAC
Screen Reader UX
Designs

Coding Standards

Repository use guidelines

Isabella-Mitchell and others added 6 commits

October 17, 2024 17:19


          WSTEAM1-1349: Initial commit|

d3a2ab5


          WSTEAM1-1349: Implements Screen Reader UX

6e2cf02


          WSTEAM1-1367: Add styles

422ea18


          WSTEAM1-1349: Fix typo

5bf4774


          WSTEAM1-1349: Update spacing. Remove textDecoration

0318d06


          WSTEAM1-1349: Update

3f61500

shayneahchoon assigned shayneahchoon and Isabella-Mitchell and unassigned shayneahchoon

shayneahchoon and others added 8 commits

October 21, 2024 10:51


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

a0a91f2


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

87f7aa8


          WSTEAM1-1349: Add e2e tests (#12074)

663ced9

* WSTEAM1-1349: Update

* WSTEAM1-1349: Update


          WSTEAM1-1349: Update

3a9e6e0


          WSTEAM1-1349: Update

d788f46


          WSTEAM1-1349: Update translations


          WSTEAM1-1349: Add meta tags

7b1ac14


          WSTEAM1-1349: Update

fbbdefd

shayneahchoon marked this pull request as ready for review

October 22, 2024 13:33


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

072922c

amoore108 reviewed

View reviewed changes

cypress/e2e/pages/articles/testsForLiteOnly.js Outdated Show resolved Hide resolved

amoore108 reviewed

View reviewed changes

src/app/components/LiteSiteCta/index.tsx Outdated Show resolved Hide resolved

amoore108 reviewed

View reviewed changes

src/app/components/LiteSiteCta/index.tsx Show resolved Hide resolved

shayneahchoon added 2 commits

October 22, 2024 14:48


          WSTEAM1-1349: Update

df8bf71


          WSTEAM1-1349: Add changes

72c199b

HarveyPeachey reviewed

View reviewed changes

cypress/e2e/pages/articles/testsForLiteOnly.js Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Outdated Show resolved Hide resolved

karinathomasbbc reviewed

View reviewed changes

cypress/e2e/pages/articles/testsForLiteOnly.js Outdated Show resolved Hide resolved

greenc05 reviewed

View reviewed changes

greenc05 left a comment

Super stuff. Couple of minor comments.

Also the focus indicator looks a little odd when displayed on the first link but I guess there isn't much we can do about that?

src/app/components/LiteSiteCta/index.test.tsx Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/liteSiteConfig.tsx Show resolved Hide resolved

src/app/components/Metadata/index.tsx Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/index.styles.tsx Outdated Show resolved Hide resolved

Isabella-Mitchell added 2 commits

October 23, 2024 12:35


          WSTEAM1-1349: Adds Gahuza lite site information link

3f9c05d


          WSTEAM1-1349: Adds width height to svg to ensure increase with browse…

5b41330

…r font settings

Isabella-Mitchell and others added 6 commits

October 23, 2024 12:36


          WSTEAM1-1349: Rewords tests

cd2dad4


          WSTEAM1-1349: Removes unnecessary span

f142a6a


          WSTEAM1-1349: Adds small margin under message to permit focus indicator

bcaef4e


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

da2c9b9


          WSTEAM1-1349: Set up .lite Integration tests

ea6006e


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

ee98bad

amoore108 approved these changes

View reviewed changes

Contributor

amoore108 left a comment

Nice work!

Isabella-Mitchell added 4 commits

October 24, 2024 13:48


          WSTEAM1-1349: Replace visuallyHiddenText with Hidden Text element

49bc1d6


          WSTEAM1-1349: Adds e2e coverage for link journeys

026b6eb


          WSTEAM1-1349: Update snapshot

3b915be


          WSTEAM1-1349: Wrap all e2e tests in service check statement

1434ab1

karinathomasbbc reviewed

View reviewed changes

cypress/e2e/pages/articles/testsForLiteOnly.js Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Show resolved Hide resolved

src/app/legacy/containers/Header/index.jsx Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Show resolved Hide resolved

cypress/e2e/pages/articles/testsForLiteOnly.js Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/index.test.tsx Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/index.test.tsx Outdated Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Show resolved Hide resolved

src/app/components/LiteSiteCta/index.tsx Show resolved Hide resolved

Isabella-Mitchell and others added 3 commits

October 25, 2024 08:35


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

b1202bc


          WSTEAM1-1349: Updates tests

ef7b4c2


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

12545df

karinathomasbbc approved these changes

View reviewed changes

amoore108 and others added 4 commits

October 29, 2024 16:24


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

35d03e0


          adds spacing changes and hcm fixes

d0200e4


          Merge branch 'latest' into WSTEAM1-1349-lite-site-cta

af2724c


          updates integration snapshot

40044d3

amoore108 approved these changes

View reviewed changes

HarveyPeachey added 2 commits

October 30, 2024 10:17


          adds metadata.json for litesitecta

caac1b1


          adds readme and metadata to story for litecta

f751cab

HarveyPeachey merged commit 46b9938 into latest

11 checks passed

HarveyPeachey deleted the WSTEAM1-1349-lite-site-cta branch

October 30, 2024 11:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shayneahchoon shayneahchoon left review comments

HarveyPeachey HarveyPeachey left review comments

greenc05 greenc05 left review comments

karinathomasbbc karinathomasbbc approved these changes

amoore108 amoore108 approved these changes

Labels

None yet