Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#757 - Remove external trade option from the trade widget #761

Merged
merged 3 commits into from
Nov 22, 2023
Merged

#757 - Remove external trade option from the trade widget #761

merged 3 commits into from
Nov 22, 2023

Conversation

pingustar
Copy link
Collaborator

@pingustar pingustar linked an issue Nov 20, 2023 that may be closed by this pull request
Cleanup: Remove external trade option from the trade widget #757
Closed
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d2ac5e3
Status: ✅  Deploy successful!
Preview URL: https://3cc66e5a.falafel.pages.dev
Branch Preview URL: https://externaltokens.falafel.pages.dev

View logs

zavelevsky
zavelevsky previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashachaf
ashachaf previously approved these changes Nov 22, 2023
View reviewed changes
@pingustar pingustar dismissed stale reviews from ashachaf and zavelevsky via a5baaab November 22, 2023 15:41
@pingustar pingustar requested a review from zavelevsky November 22, 2023 15:53
zavelevsky
zavelevsky approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingustar pingustar merged commit 73bd974 into main Nov 22, 2023
5 checks passed
@pingustar pingustar deleted the externalTokens branch November 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavelevsky zavelevsky zavelevsky approved these changes

@ashachaf ashachaf ashachaf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup: Remove external trade option from the trade widget
3 participants
@pingustar @zavelevsky @ashachaf