Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Remove external trade option from the trade widget #757

Closed
ashachaf opened this issue Nov 20, 2023 · 0 comments · Fixed by #761
Closed

Cleanup: Remove external trade option from the trade widget #757

ashachaf opened this issue Nov 20, 2023 · 0 comments · Fixed by #761
Assignees
@pingustar
Labels
enhancement New feature or request

Comments

@ashachaf
Copy link
Collaborator

currently, we have a 3rd party integration that provides trade option for tokens that are not supported on bancor.

flow:

  1. open trade
  2. input token pair that does not exists on bancor (ETH/CHESS) https://app.bancor.network/trade?from=0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE&to=0xe1bA035fE04200dA932378C4509e1fafDd08e187
    expected: IF (sourceToken) or (destinationToken) = (do not have a pool) or (have a pool with trading disabled) or (have a pool with balance 0), do not show the option to select the token
@ashachaf ashachaf added the enhancement New feature or request label Nov 20, 2023
@ashachaf ashachaf assigned ashachaf and pingustar and unassigned ashachaf Nov 20, 2023
@pingustar pingustar mentioned this issue Nov 20, 2023
Merged
@pingustar pingustar linked a pull request Nov 20, 2023 that will close this issue
#757 - Remove external trade option from the trade widget #761
Merged
pingustar added a commit that referenced this issue Nov 22, 2023
@pingustar
Merge pull request #761 from bancorprotocol/externalTokens
73bd974 
#757 - Remove external trade option from the trade widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pingustar pingustar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#757 - Remove external trade option from the trade widget bancorprotocol/webapp-v3
2 participants
@pingustar @ashachaf