Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Make test_essential_features more resilient #6558

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Test] Make test_essential_features more resilient #6558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c810aa2
[Test] Make `test_essential_features` more resilient
gmarciani Nov 11, 2024
a438e03
Merge branch 'develop' into wip/mgiacomo/3120/fix-test-essential-feat…
gmarciani Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/integration-tests/tests/basic/log_rotation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ def _wait_file_not_empty(remote_command_executor, file_path, compute_node_ip=Non
size = remote_command_executor.run_remote_command(f"stat --format=%s {file_path}").stdout
assert_that(size).is_not_equal_to("0")

def _touch_file(remote_command_executor, file_path, compute_node_ip=None):
"""Touch a file on head node or compute node."""
command = f"touch {file_path}"
if compute_node_ip:
_run_command_on_node(remote_command_executor, command, compute_node_ip)
else:
remote_command_executor.run_remote_command(command)


def _run_command_on_node(remote_command_executor, command, compute_node_ip=None):
"""Run remote command on head node or compute node."""
Expand Down Expand Up @@ -159,10 +167,14 @@ def _test_logs_are_rotated(os, logs, remote_command_executor, before_log_rotatio

def _test_logs_written_to_new_file(logs, remote_command_executor, compute_node_ip=None):
"""Test newly generated logs write to log_file.log instead of log_file.log.1."""
# test logs are written to new log files after rotation
# test logs are written to new log files after rotation.
# For those logs that do not necessarily have new entries,
# we touch the file to force the existence for later checks.
for log in logs:
if log.get("trigger_new_entries"):
_wait_file_not_empty(remote_command_executor, log.get("log_path"), compute_node_ip)
else:
_touch_file(remote_command_executor, log.get("log_path"), compute_node_ip)


def _test_logs_uploaded_to_cloudwatch(
Expand Down
Loading