[Test] Make test_essential_features more resilient
#6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by accepting the legit scenario where logs, such as compute_console_output.log, may not have new content from compute nodes after rotation. Signed-off-by: Giacomo Marciani <[email protected]>
gmarciani
added
skip-changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Make
test_essential_featuresmore resilient by accepting the legit scenario where logs, such as compute_console_output.log, may not have new content from compute nodes after rotation.for those files that we know do not necessarily trigger new entries, we touch the log file after rotation to make sure later checks can be performed.
Without this change the test intermittently fails when the log
compute_console_output.logdoes not exist after a log rotation. However, this is not a failing scenario:compute_console_output.logmay be empty if there are no new logs from compute nodes. This may happen if the job submission reuses an existing compute node.Tests
test_essential_featuresBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.