Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump The Lounge to v2.7.1 #28

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Bump The Lounge to v2.7.1 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5b387
Bump The Lounge to v2.7.1
astorije Feb 19, 2018
e03f67e
Remove jsonlint validation for now, since it got broken when npm depr…
astorije Feb 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018 Jérémie Astori
Copyright (c) 2015 Jérémie Astori
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was not intentional

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, @andreineculau!
It was intentional actually, and the reason is the same as mentioned here: thelounge/thelounge-deb#16

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say there that you believe in bumping the copyright years when the project is updated. You have already done so in January 2018 for this project. Here you reversed the change. Anyways, i was nitpicking while looking at the actual jsonlint disabling

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I meant specifically xPaw's comment:

My understanding is that copyright years shouldn't be updated. https://stackoverflow.com/a/2391555/2200891

So most likely I was wrong, and corrected my wrong here :)

Yeah, disabling jsonlint isn't great, but npm...


Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ What this role does:

- Installs [Supervisor](http://supervisord.org/) to run The Lounge in the background
- Installs [NodeSource's Node.js 4.x LTS](https://nodejs.org/en/download/package-manager/#debian-and-ubuntu-based-linux-distributions)
- Installs [The Lounge v2.7.0](https://github.com/thelounge/lounge/blob/master/CHANGELOG.md)
- Installs [The Lounge v2.7.1](https://github.com/thelounge/lounge/blob/master/CHANGELOG.md)
- Creates a system user to own the `lounge` process
- Configures The Lounge [as a private server](https://theloungegithub.io/docs/server/configuration.html#public) to enable user login
- Configures users as defined in your playbook variables, each with logging support
Expand Down
2 changes: 1 addition & 1 deletion defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ lounge_prefetch: false
lounge_reverse_proxy: false
lounge_theme: example
lounge_users: []
lounge_version: "2.7.0"
lounge_version: "2.7.1"
4 changes: 2 additions & 2 deletions tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
state: present
with_items:
- esprima
- jsonlint
# - jsonlint
become: yes

- name: Retrieve the location of the global `node_modules` directory
Expand Down Expand Up @@ -118,7 +118,7 @@
group: lounge
mode: "0660"
force: no # Do not overwrite existing users to not erase networks
validate: 'jsonlint -q %s'
# validate: 'jsonlint -q %s'
with_items: "{{ lounge_users }}"
become: yes
notify: Restart supervisord program
Expand Down