chore: replace more ctors with initializers

src/graph.ts

@@ -325,11 +325,7 @@ export class GraphForwarder {
      * For each note generator-to-instrument connection, stores the previous
      * notes (in MIDI pitches) that were active in the previous pulse.
      */
-    private prevNoteMap: Map<string, number[]>;
-
-    constructor() {
-        this.prevNoteMap = new Map();
-    }
+    private prevNoteMap: Map<string, number[]> = new Map();
 
     /**
      * Traces the given graph, forwarding Vestige-generated data to out-of-graph

src/nodes/ChorusNode.tsx

@@ -57,7 +57,7 @@ export class ChorusAudioEffect implements AudioEffect {
     wet: 0.4
   });
 
-  constructor () {
+  constructor() {
     this.chorus.start();
   }
 

src/nodes/FilterNode.tsx

@@ -40,7 +40,12 @@ export class FilterNodeData extends EffectNodeData {
 };
 
 export class FilterAudioEffect implements AudioEffect {
-  filter: tone.Filter;
+  filter: tone.Filter = new tone.Filter({
+    frequency: cutoffScalarToHz(0.5),
+    Q: scalarToResonance(0.5),
+    rolloff: -24,
+    type: "lowpass"
+  });
 
   connectTo(dst: AudioDestination): void {
     dst.accept(this.filter);
@@ -59,15 +64,6 @@ export class FilterAudioEffect implements AudioEffect {
     assert(handleId == SIGNAL_INPUT_HID_MAIN, `Unknown signal input handle ID ${handleId}`);
     return unaryAudioDestination(this.filter);
   }
-
-  constructor() {
-    this.filter = new tone.Filter({
-      frequency: cutoffScalarToHz(0.5),
-      Q: scalarToResonance(0.5),
-      rolloff: -24,
-      type: "lowpass"
-    });
-  }
 }
 
 export class FilterNodeSerializer implements NodeDataSerializer<FilterNodeData> {

src/nodes/LfoNode.tsx

@@ -39,10 +39,10 @@ export class LfoNodeData extends ValueNodeData {
 };
 
 export class LfoValueGenerator implements ValueGenerator {
-  shape: LfoShape;
-  frequency: number;
-  min: number;
-  max: number;
+  shape: LfoShape = "sine";
+  frequency: number = 1;
+  min: number = 0;
+  max: number = 1;
 
   generate(time: number): number {
     switch (this.shape) {
@@ -54,13 +54,6 @@ export class LfoValueGenerator implements ValueGenerator {
         return scale(biToUni(lfoSaw(time, this.frequency)), this.min, this.max);
     }
   }
-
-  constructor() {
-    this.shape = "sine";
-    this.frequency = 1;
-    this.min = 0;
-    this.max = 1;
-  }
 }
 
 export class LfoNodeSerializer implements NodeDataSerializer<LfoNodeData> {

src/nodes/MixNode.tsx

@@ -17,16 +17,11 @@ const INPUT_A = signalInHandleId("a");
 const INPUT_B = signalInHandleId("b");
 
 export class MixNodeData extends EffectNodeData {
-  effect: MixAudioEffect;
-
-  constructor() {
-    super();
-    this.effect = new MixAudioEffect();
-  }
+  effect = new MixAudioEffect();
 };
 
 export class MixAudioEffect implements AudioEffect {
-  gain: tone.Gain;
+  gain = new tone.Gain();
   inputA?: tone.ToneAudioNode;
   inputB?: tone.ToneAudioNode;
 
@@ -47,10 +42,6 @@ export class MixAudioEffect implements AudioEffect {
     assert(handleId == INPUT_A || handleId == INPUT_B, `Unknown signal input handle ID ${handleId}`);
     return unaryAudioDestination(this.gain);
   }
-
-  constructor() {
-    this.gain = new tone.Gain();
-  }
 }
 
 export class MixNodeSerializer extends NullNodeDataSerializer<MixNodeData> {

src/nodes/PentatonicChordsNode.tsx

@@ -22,7 +22,7 @@ export class PentatonicChordsGenerator implements PlainNoteGenerator {
   seedOffset: number;
   lastNotes: number[] = [];
 
-  constructor(
+  constructor (
     public chordLength: number = 6,
     public minNotes: number = 4,
     public maxNotes: number = 6,

src/nodes/PentatonicMelodyNode.tsx

@@ -21,7 +21,7 @@ export class PentatonicMelodyGenerator implements PlainNoteGenerator {
   offset: number;
   lastNotes: number[] = [];
 
-  constructor(
+  constructor (
     public density: number = 50,
     public octave: number = 4,
     public pitchRange: number = 6,

src/nodes/ReverbNode.tsx

@@ -47,7 +47,11 @@ export class ReverbNodeData extends EffectNodeData {
 };
 
 export class ReverbAudioEffect implements AudioEffect {
-  reverb: tone.Reverb;
+  reverb: tone.Reverb = new tone.Reverb({
+    decay: 4.00,
+    preDelay: 20 / 1000,
+    wet: 0.5
+  });
 
   connectTo(dst: AudioDestination): void {
     dst.accept(this.reverb);
@@ -66,14 +70,6 @@ export class ReverbAudioEffect implements AudioEffect {
     assert(handleId == SIGNAL_INPUT_HID_MAIN, `Unknown signal input handle ID ${handleId}`);
     return unaryAudioDestination(this.reverb);
   }
-
-  constructor() {
-    this.reverb = new tone.Reverb({
-      decay: 4.00,
-      preDelay: 20 / 1000,
-      wet: 0.5
-    });
-  }
 }
 
 export class ReverbNodeSerializer implements NodeDataSerializer<ReverbNodeData> {

src/nodes/SamplerNode.tsx

@@ -70,7 +70,7 @@ export class SamplerAudioGenerator implements AudioGenerator {
     this.sampler.connect(this.out);
   }
 
-  constructor () {
+  constructor() {
     this.sampler.connect(this.out);
   }
 

src/nodes/SynthNode.tsx

@@ -70,7 +70,7 @@ export class SynthNodeData extends InstrumentNodeData {
     this.generator.synth.set({ envelope: env });
   }
 
-  constructor () {
+  constructor() {
     super();
 
     this.generator = new SynthAudioGenerator();
@@ -84,15 +84,11 @@ export class SynthNodeData extends InstrumentNodeData {
 };
 
 export class SynthAudioGenerator implements AudioGenerator {
-  synth: tone.PolySynth;
+  synth = new tone.PolySynth(tone.Synth, { oscillator: { type: this.waveform} });
   private _waveform: Waveform = "sine";
   private _unisonSpread: number = 20;
   private _unisonCount: number = 1;
 
-  constructor() {
-    this.synth = new tone.PolySynth(tone.Synth, { oscillator: { type: this.waveform} });
-  }
-
   /** Fully applies oscillator settings, changing its type. May produce audible clicks.  */
   private fullyApplyOsc() {
     if (this._unisonCount > 1) {