chore: prefer direct initialization instead of constructors

ascpixi · Dec 24, 2024 · 78a59f3 · 78a59f3
1 parent 649cfa3
commit 78a59f3
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 48 deletions.
diff --git a/src/collections.ts b/src/collections.ts
@@ -6,11 +6,9 @@ export function toAugmented<T>(array: T[]): ArrayProcessor<T> {
  * Allows for extended functionality when modifying arrays.
  */
 export class ArrayProcessor<T> {
-    array: T[];
-
-    constructor (arr: T[]) {
-        this.array = arr;
-    }
+    constructor (
+        private array: T[]
+    ) {}
 
     collect() { return this.array; }
 

diff --git a/src/graph.ts b/src/graph.ts
@@ -43,12 +43,8 @@ export type BaseNodeData = Record<string, unknown> & {
 export abstract class NoteGeneratorNodeData<TParamType extends string = string> implements BaseNodeData {
     [x: string]: unknown;
 
-    nodeType: "NOTES";
+    nodeType = "NOTES" as const;
     abstract generator: PlainNoteGenerator | ParametricNoteGenerator<TParamType>;
-
-    constructor () {
-        this.nodeType = "NOTES";
-    }
 }
 
 /**
@@ -58,15 +54,10 @@ export abstract class NoteGeneratorNodeData<TParamType extends string = string>
 export abstract class InstrumentNodeData implements BaseNodeData {
     [x: string]: unknown;
 
-    nodeType: "INSTRUMENT";
-    parameters: { [handleName: string]: Automatable };
+    nodeType = "INSTRUMENT" as const;
+    parameters: { [handleName: string]: Automatable } = {};
 
     abstract generator: AudioGenerator;
-
-    constructor () {
-        this.nodeType = "INSTRUMENT";
-        this.parameters = {};
-    }
 };
 
 /**
@@ -75,15 +66,10 @@ export abstract class InstrumentNodeData implements BaseNodeData {
 export abstract class EffectNodeData implements BaseNodeData {
     [x: string]: unknown;
 
-    nodeType: "EFFECT";
-    parameters: { [handleName: string]: Automatable };
+    nodeType = "EFFECT" as const;
+    parameters: { [handleName: string]: Automatable } = {};
 
     abstract effect: AudioEffect;
-
-    constructor () {
-        this.nodeType = "EFFECT";
-        this.parameters = {};
-    }
 }
 
 /**
@@ -93,12 +79,8 @@ export abstract class EffectNodeData implements BaseNodeData {
 export abstract class ValueNodeData implements BaseNodeData {
     [x: string]: unknown;
 
-    nodeType: "VALUE";
+    nodeType = "VALUE" as const;
     abstract generator: ValueGenerator;
-
-    constructor () {
-        this.nodeType = "VALUE";
-    }
 }
 
 export type NoInputs<T> = { [paramName in keyof never]: T };

diff --git a/src/nodes/LfoNode.tsx b/src/nodes/LfoNode.tsx
@@ -35,13 +35,7 @@ function biToUni(x: number) {
 }
 
 export class LfoNodeData extends ValueNodeData {
-  generator: LfoValueGenerator;
-
-  constructor () {
-    super();
-
-    this.generator = new LfoValueGenerator();
-  }
+  generator = new LfoValueGenerator();
 };
 
 export class LfoValueGenerator implements ValueGenerator {

diff --git a/src/nodes/PentatonicChordsNode.tsx b/src/nodes/PentatonicChordsNode.tsx
@@ -58,12 +58,7 @@ export class PentatonicChordsGenerator implements PlainNoteGenerator {
 }
 
 export class PentatonicChordsNodeData extends NoteGeneratorNodeData {
-  generator: PentatonicChordsGenerator;
-
-  constructor () {
-    super();
-    this.generator = new PentatonicChordsGenerator();
-  }
+  generator = new PentatonicChordsGenerator();
 };
 
 export class PentatonicChordsNodeSerializer implements NodeDataSerializer<PentatonicChordsNodeData> {

diff --git a/src/nodes/PentatonicMelodyNode.tsx b/src/nodes/PentatonicMelodyNode.tsx
@@ -70,12 +70,7 @@ export class PentatonicMelodyGenerator implements PlainNoteGenerator {
 }
 
 export class PentatonicMelodyNodeData extends NoteGeneratorNodeData {
-  generator: PentatonicMelodyGenerator;
-
-  constructor () {
-    super();
-    this.generator = new PentatonicMelodyGenerator();
-  }
+  generator = new PentatonicMelodyGenerator();
 };
 
 export class PentatonicMelodyNodeSerializer implements NodeDataSerializer<PentatonicMelodyNodeData> {