[Consignments] Reenable Convection Stitching

[damassi]

Related: artsy/convection#504

This unwires unstitched mutations related to creating / updating a consignments submission, in favor of stitching.

Now that convection PR has been merged, if one pulls down this PR and points Eigen at it, can create stitched submission at consignments staging. See https://convection-staging.artsy.net/admin/submissions/31121 for an example.

The schema conflicts below relate to old consignments convection schema, before it was modified to match MP, and can thus be ignored.

This is a phased roll-out:

• Merge convection PR up above
• Merge this PR
• Enable ENABLE_CONSIGNMENTS_STITCHING on staging
• Test submissions in iOS app thoroughly
• Deploy to prod

There are details in the PR up above, but the main change required was to match the types / schema in Convection to what was manually built using GraphQL loaders and the REST API. This was required so as to avoid breaking changes to our iOS app and enable a code-free transition on the Eigen side of things.

If everything goes smoothly we can follow-up and delete a bunch of consignments code from MP as it will be entirely replaced by stitching.

This flow has been tested by:

1. Setting CONVECTION_API_BASE=http://localhost:5000/api
2. Setting ENABLE_CONSIGNMENTS_STITCHING=true`
3. Booting Convection
4. Running yarn sync-remote-schema to sync Convection's localhost schema
5. Booting MP
6. Booting Eigen and running the "shake device" action to show settings screen where MP endpoint was then pointed at MP localhost
7. Creating a new Consignments submission, including image upload.

History

Previously, we ran into issues stitching in Convection. I believe this was before we had a pattern for transforming / aliasing type names across services. The problems observed in this issue no longer seem to apply.

[artsy-peril]

Warnings

⚠️

The V2 schema in this PR has breaking changes with Force. Remember to update Reaction if necessary. Type 'Asset' was removed Field 'ConsignmentSubmissionConnection.edges' changed type from '[ConsignmentSubmissionEdge]' to '[SubmissionEdge]' Field 'artistID' was removed from object type 'ConsignmentSubmission' Field 'authenticityCertificate' was removed from object type 'ConsignmentSubmission' Field 'dimensionsMetric' was removed from object type 'ConsignmentSubmission' Field 'editionNumber' was removed from object type 'ConsignmentSubmission' Field 'editionSize' was removed from object type 'ConsignmentSubmission' Field 'locationCity' was removed from object type 'ConsignmentSubmission' Field 'locationCountry' was removed from object type 'ConsignmentSubmission' Field 'locationState' was removed from object type 'ConsignmentSubmission' Field 'userID' was removed from object type 'ConsignmentSubmission' Field 'ConsignmentSubmission.category' changed type from 'SubmissionCategoryAggregation' to 'ConsignmentSubmissionCategoryAggregation' Field 'ConsignmentSubmission.edition' changed type from 'Boolean' to 'String' Field 'ConsignmentSubmission.state' changed type from 'SubmissionStateAggregation' to 'ConsignmentSubmissionStateAggregation' Input field 'CreateSubmissionMutationInput.category' changed type from 'SubmissionCategoryAggregation' to 'ConsignmentSubmissionCategoryAggregation' Input field 'CreateSubmissionMutationInput.dimensionsMetric' changed type from 'SubmissionDimensionAggregation' to 'String' Input field 'CreateSubmissionMutationInput.state' changed type from 'SubmissionStateAggregation' to 'ConsignmentSubmissionStateAggregation' Input field 'userID' was removed from input object type 'CreateSubmissionMutationInput' Input field 'UpdateSubmissionMutationInput.id' changed type from 'String!' to 'ID!' Input field 'UpdateSubmissionMutationInput.category' changed type from 'SubmissionCategoryAggregation' to 'ConsignmentSubmissionCategoryAggregation' Input field 'UpdateSubmissionMutationInput.dimensionsMetric' changed type from 'SubmissionDimensionAggregation' to 'String' Input field 'UpdateSubmissionMutationInput.state' changed type from 'SubmissionStateAggregation' to 'ConsignmentSubmissionStateAggregation' Input field 'userID' was removed from input object type 'UpdateSubmissionMutationInput' Input field 'AddAssetToConsignmentSubmissionInput.submissionID' changed type from 'String!' to 'ID!' Field 'AddAssetToConsignmentSubmissionPayload.asset' changed type from 'Asset' to 'ConsignmentSubmissionCategoryAsset'

Generated by 🚫 dangerJS against 2e242d6

[damassi]

@mzikherman / @jonallured - this is ready to go.

[ashfurrow]

Very cool! Makes sense to me, thank you for annotating soon-to-be-deleted tests. Very very cool how much code we get to delete 🤩 The schema changes themselves appear to be backwards-compatible, but I agree that thorough testing on staging would be prudent.

To make sure we have adequate staging testing before promoting to prod, I'm going to assign this back to @damassi to merge at his discretion.