[Stitching] Ensure schema matches existing MPv2 definitions #504
Conversation
damassi
force-pushed
the
update-mutations
branch
from
6b6b7bb to
75f28bf
Compare
damassi
force-pushed
the
update-mutations
branch
from
75f28bf to
d0b49a9
Compare
| input_field :additional_info, types.String | ||
| input_field :artist_id, types.String | ||
| input_field :authenticity_certificate, types.Boolean | ||
| input_field :additionalInfo, types.String |
There was a problem hiding this comment.
graphql-ruby has a nice (or rather, confusing) feature where it will automatically take snake_case fields and camelize them (convenient for MPv2). However, this doesn't apply to inputs.
damassi
force-pushed
the
update-mutations
branch
from
d0b49a9 to
165ca16
Compare
| @@ -49,9 +52,12 @@ def self.resolve(_obj, args, context) | |||
| raise(GraphQL::ExecutionError, 'Submission Not Found') | |||
| end | |||
|
|
|||
| # FIXME: Why does the API reject this property? | |||
| params.delete('dimensions_metric') | |||
There was a problem hiding this comment.
Not sure whats up here, but Rails will reject a submission if this property is included, only a naked numeric value seems to be used in the UI.
|
@pepopowitz if I'm understanding right, the schema here in Convection is changing in a breaking way (to any consumers of the GraphQL schema in Convection). It's just that, it isn't stitched into Metaphysics (so the iOS app uses Metaphysics schema -> Convection data loaders using the REST endpoints). The web app directly uses the Convection REST endpoints. So, making breaking changes to the Convection GraphQL schema is necessary in order to be able to stitch in without breaking changes to the Metaphysics consumers of that schema (just the iOS app). Implicit in this is the assumption/discovery(?!) that there are no consumers of the current Convection GraphQL API, and so thus this is ok to break. Might be possible to confirm no consumers of the GraphQL API endpoint in Papertrail or something? |
That's the assumption, and if indeed there are consumers those we can change without worrying too much -- but we cant change MP as thats where our mobile client connects to. |
damassi
force-pushed
the
update-mutations
branch
2 times, most recently
from
fa3fa01 to
dd1e699
Compare
damassi
force-pushed
the
update-mutations
branch
from
dd1e699 to
03ca14b
Compare
Related: artsy/metaphysics#2221
This PR updates our GraphQL schema to match the currently unstitched MPv2 schema. We had to make these changes on the convection side because to enable stitching we had to take old mobile app versions into account, and if we modified the schema on the MP side it would be a breaking change.
There's some
camelCaseversussnake_caseconversion that we had to do to line things up, but nothing too severe or blocking (there were only three mutations to update).The other thing we had to change was the GraphQL type names. There were slight differences between what MP uses and what convection had defined.
Follow-up steps will be to open an additional PR to MP that removes Convection code unrelated to stitching, including three manually defined mutations that communicate with Convection via the REST API.