Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update alert screen routes #9590

Merged
merged 2 commits into from
Nov 23, 2023
Merged

chore: update alert screen routes #9590

merged 2 commits into from
Nov 23, 2023

Conversation

dblandin
Copy link
Member

@dblandin dblandin commented Nov 23, 2023 •
edited
Loading

Description

Match web routes for deep-link support.

/my-profile/saved-search-alerts > /settings/alerts
/my-profile/saved-search-alerts/:id > /settings/alerts/:id/edit

This PR resolves ONYX-542

Screen.Recording.2023-11-23.at.14.26.36.mov

cc/ @olerichter00

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • chore: update alert screen routes — devon

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Nov 23, 2023 •
edited
Loading

This PR contains the following changes:

  • Cross-platform user-facing changes (chore: update alert screen routes — devon)

Generated by 🚫 dangerJS against bbec68f

@dblandin dblandin marked this pull request as ready for review November 23, 2023 13:29
olerichter00
olerichter00 previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

MounirDhahri
MounirDhahri reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! this should make it work on iOS. We will need to add /settings to AndroidManifest.xml as well to make sure the deep link works on Android as well

@dblandin
chore: update alert screen routes
c566e73 
Match web routes for deep-link support.

```
/my-profile/saved-search-alerts > /settings/alerts
/my-profile/saved-search-alerts/:id > /settings/alerts/:id/edit
```
@dblandin dblandin force-pushed the dblandin/alert-screen-routes branch from 33a855b to c566e73 Compare November 23, 2023 14:09
MounirDhahri
MounirDhahri approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Nov 23, 2023
@artsy-peril artsy-peril bot merged commit 355ffda into main Nov 23, 2023
@artsy-peril artsy-peril bot deleted the dblandin/alert-screen-routes branch November 23, 2023 14:31
@olerichter00 olerichter00 mentioned this pull request Nov 24, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MounirDhahri MounirDhahri MounirDhahri approved these changes

@olerichter00 olerichter00 olerichter00 left review comments

Assignees

@MounirDhahri MounirDhahri

Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dblandin @ArtsyOpenSource @olerichter00 @MounirDhahri