chore: update alert screen routes (#9590)

* chore: update alert screen routes

Match web routes for deep-link support.

```
/my-profile/saved-search-alerts > /settings/alerts
/my-profile/saved-search-alerts/:id > /settings/alerts/:id/edit
```

* chore: add `/settings` to AndroidManifest file to support deep-linking

android/app/src/main/AndroidManifest.xml

@@ -128,6 +128,7 @@
                 <data android:pathPrefix="/privacy-request" />
                 <data android:pathPrefix="/sales" />
                 <data android:pathPrefix="/search" />
+                <data android:pathPrefix="/settings" />
                 <data android:pathPrefix="/show" />
                 <data android:pathPrefix="/tag" />
                 <data android:pathPrefix="/user/conversations" />

src/app/Components/Artist/ArtistHeader.tsx

@@ -168,7 +168,7 @@ export const ArtistHeader: React.FC<Props> = ({ artist, me, onLayoutChange }) =>
           <Touchable
             haptic
             onPress={() => {
-              navigate(`/my-profile/saved-search-alerts?artistID=${artistData.internalID}`)
+              navigate(`/settings/alerts?artistID=${artistData.internalID}`)
             }}
           >
             <Text variant="xs" color="blue100">

src/app/Scenes/Artwork/ArtworkAuctionCreateAlertHeader.tsx

@@ -84,7 +84,7 @@ export const ArtworkAuctionCreateAlertHeader: FC<ArtworkAuctionCreateAlertHeader
             variant="outline"
             haptic
             onPress={() => {
-              navigate("/my-profile/saved-search-alerts")
+              navigate("/settings/alerts")
             }}
             icon={<BellIcon fill="black100" />}
             block

src/app/Scenes/MyProfile/MyProfileSettings.tsx

@@ -36,7 +36,7 @@ export const MyProfileSettings: React.FC<MyProfileSettingsProps> = ({ onSuccess
         <Separator my={1} borderColor={separatorColor} />
         <MenuItem title="Account Settings" onPress={() => navigate("my-account")} />
         <Separator my={1} borderColor={separatorColor} />
-        <MenuItem title="Saved Alerts" onPress={() => navigate("my-profile/saved-search-alerts")} />
+        <MenuItem title="Saved Alerts" onPress={() => navigate("settings/alerts")} />
         <Separator my={1} borderColor={separatorColor} />
         <MenuItem title="Follows" onPress={() => navigate("favorites")} />
         <Separator my={1} borderColor={separatorColor} />

src/app/Scenes/SavedSearchAlert/SavedSearchAlertForm.tests.tsx

@@ -815,7 +815,7 @@ describe("SavedSearchAlertForm", () => {
 
         await waitFor(() => expect(spyAlert.mock.calls[0][0]).toBe("Duplicate Alert"))
 
-        expect(navigate).toBeCalledWith("/my-profile/saved-search-alerts/internalID-1")
+        expect(navigate).toBeCalledWith("/settings/alerts/internalID-1/edit")
       })
 
       it('should call update mutation when "Replace" button is pressed', async () => {

src/app/Scenes/SavedSearchAlert/SavedSearchAlertForm.tsx

@@ -121,7 +121,7 @@ export const SavedSearchAlertForm: React.FC<SavedSearchAlertFormProps> = (props)
               goBack()
 
               requestAnimationFrame(() => {
-                navigate(`/my-profile/saved-search-alerts/${duplicateSavedSearchId}`)
+                navigate(`/settings/alerts/${duplicateSavedSearchId}/edit`)
               })
             },
           })

src/app/Scenes/SavedSearchAlert/screens/ConfirmationScreen.tests.tsx

@@ -127,7 +127,7 @@ describe(ConfirmationScreen, () => {
       fireEvent.press(manageButton!)
       await flushPromiseQueue()
 
-      expect(navigate).toHaveBeenCalledWith("/my-profile/saved-search-alerts")
+      expect(navigate).toHaveBeenCalledWith("/settings/alerts")
     })
 
     it("renders see-all button if there are more works to show", async () => {

src/app/Scenes/SavedSearchAlert/screens/ConfirmationScreen.tsx

@@ -49,7 +49,7 @@ export const ConfirmationScreen: React.FC = () => {
   const handleManageAlerts = () => {
     closeModal?.()
     requestAnimationFrame(() => {
-      navigate("/my-profile/saved-search-alerts")
+      navigate("/settings/alerts")
     })
   }
 

src/app/Scenes/SavedSearchAlertsList/Components/SavedSearchesList.tsx

@@ -80,7 +80,7 @@ export const SavedSearchesList: React.FC<SavedSearchesListProps> = (props) => {
           <SavedSearchListItem
             title={item.displayName}
             onPress={() => {
-              navigate(`my-profile/saved-search-alerts/${item.internalID}`)
+              navigate(`settings/alerts/${item.internalID}/edit`)
             }}
           />
         )

src/app/routes.ts

@@ -227,8 +227,6 @@ function getDomainMap(): Record<string, RouteMatcher[] | null> {
     addRoute("/my-profile/payment", "MyProfilePayment"),
     addRoute("/my-profile/payment/new-card", "MyProfilePaymentNewCreditCard"),
     addRoute("/my-profile/push-notifications", "MyProfilePushNotifications"),
-    addRoute("/my-profile/saved-search-alerts", "SavedSearchAlertsList"),
-    addRoute("/my-profile/saved-search-alerts/:savedSearchAlertId", "EditSavedSearchAlert"),
     addRoute("/my-profile/settings", "MyProfileSettings"),
     addRoute("/new-for-you", "NewWorksForYou"),
     addRoute("/new-works-from-galleries-you-follow", "NewWorksFromGalleriesYouFollow"),
@@ -252,6 +250,8 @@ function getDomainMap(): Record<string, RouteMatcher[] | null> {
     addRoute("/search", "Search"),
     addRoute("/sell/inquiry", "ConsignmentInquiry"),
     addRoute("/selling-with-artsy", "MyCollectionSellingWithartsyFAQ"),
+    addRoute("/settings/alerts", "SavedSearchAlertsList"),
+    addRoute("/settings/alerts/:savedSearchAlertId", "EditSavedSearchAlert"),
     addRoute("/settings/dark-mode", "DarkModeSettings"),
     addRoute("/show/:showID", "Show"),
     addRoute("/show/:showID/info", "ShowMoreInfo"),

src/app/system/navigation/navigate.tests.tsx

@@ -238,7 +238,7 @@ describe(navigate, () => {
 
   it("pop to root tab view in cases where that's required", async () => {
     await navigate("my-profile/payment")
-    await navigate("my-profile/saved-search-alerts", {
+    await navigate("settings/alerts", {
       popToRootTabView: true,
       showInTabName: "profile",
     })