feat: support navigating to artist artworks grid - mounir #9403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
commented
Oct 11, 2023
| searchCriteriaID: parsed.search_criteria_id, | ||
| } | ||
|
|
||
| if ((matchRoute(targetHref) as any).module === "Artist") { |
There was a problem hiding this comment.
matchRoute return type depends on the module type. I could have typecasted this in a different way probably. let me know if you have better suggestions
MounirDhahri
commented
Oct 11, 2023
| @@ -92,7 +92,7 @@ describe(AutosuggestSearchResult, () => { | |||
| tree.root.findByType(Touchable).props.onPress() | |||
| await new Promise((r) => setTimeout(r, 50)) | |||
| expect(inputBlurMock).toHaveBeenCalled() | |||
| expect(navigate).toHaveBeenCalledWith(result.href, { passProps: { initialTab: "Artworks" } }) | |||
| expect(navigate).toHaveBeenCalledWith(result.href, { passProps: undefined }) | |||
There was a problem hiding this comment.
no need to inject any props if you didn't press on "Artworks" or "AuctionResults"
MounirDhahri
force-pushed
the
feat/scroll-down-to-artworks-on-artist-artworks-press
branch
from
ba31b32 to
3dbe878
Compare
gkartalis
reviewed
Oct 11, 2023
MounirDhahri
deleted the
feat/scroll-down-to-artworks-on-artist-artworks-press
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the foundation for the work on ONYX-421 ONYX-422 ONYX-423
Description
This PR adds support of URLs query params injection to navigate to the artworks grid.
Screen.Recording.2023-10-11.at.15.39.45.mov
Remaining work:
Screen.Recording.2023-10-11.at.16.05.59.mov
Blocked. by: artsy/palette-mobile#159
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.