fix: broken test

artsy · Oct 11, 2023 · 5d9a5d0 · 5d9a5d0
1 parent 3dbe878
commit 5d9a5d0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/app/Scenes/Activity/ActivityItem.tests.tsx b/src/app/Scenes/Activity/ActivityItem.tests.tsx
@@ -116,6 +116,8 @@ describe("ActivityItem", () => {
             paramValue: "-published_at",
           },
         ],
+        scrollToArtworksGrid: true,
+        searchCriteriaID: undefined,
       },
     })
   })
@@ -137,6 +139,7 @@ describe("ActivityItem", () => {
 
     expect(navigate).toHaveBeenCalledWith(alertTargetUrl, {
       passProps: {
+        scrollToArtworksGrid: true,
         searchCriteriaID: "searchCriteriaId",
         predefinedFilters: [
           {

diff --git a/src/app/Scenes/Search/components/AutosuggestSearchResult.tsx b/src/app/Scenes/Search/components/AutosuggestSearchResult.tsx
@@ -200,7 +200,7 @@ function navigateToResult(result: AutosuggestResult, props?: PassedProps) {
   } else if (result.displayType === "Fair") {
     navigateToEntity(result.href!, EntityType.Fair, SlugType.ProfileID)
   } else if (result.__typename === "Artist") {
-    navigate(result.href!, { passProps: props })
+    navigate(`${result.href!}/artworks`, { passProps: props })
   } else {
     navigate(result.href!)
   }

diff --git a/src/app/routes.ts b/src/app/routes.ts
@@ -138,10 +138,10 @@ function getDomainMap(): Record<string, RouteMatcher[] | null> {
       ...params,
       initialTab: "Insights",
     })),
-    addRoute("/artist/:artistID/artworks", "Artist", (params) => ({
-      ...params,
-      scrollToArtworksGrid: true,
-    })),
+    // addRoute("/artist/:artistID/artworks", "Artist", (params) => ({
+    //   ...params,
+    //   initialTab: "Insights",
+    // })),
     addRoute("/artist/:artistID/shows", "ArtistShows"),
 
     // Routes `/artist/:artistID/*` and `"/:profile_id_ignored/artist/:artistID"`