-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ONYX-369): navigate to create alerts instead of filers #9350
Merged
MounirDhahri
merged 6 commits into
main
from
feat/navigate-to-create-alerts-instead-of-filers
Oct 4, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
eab68d7
feat: hide price range filters when new alerts filters are enabled
MounirDhahri ddba5cb
feat: add Add Filters button to create alert modal
MounirDhahri 72e3501
chore: address review comments
MounirDhahri 4c5d399
feat: navigate to create alert modal on create alert press
MounirDhahri 211c42a
fix: lazy rebase conflict
MounirDhahri 8753156
chore: fix merge conflicts
MounirDhahri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/app/Components/Artist/ArtistArtworks/hooks/useCreateSavedSearchModalFilters.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { ScreenOwnerType } from "@artsy/cohesion" | ||
import { getUnitedSelectedAndAppliedFilters } from "app/Components/ArtworkFilter/ArtworkFilterHelpers" | ||
import { ArtworksFiltersStore } from "app/Components/ArtworkFilter/ArtworkFilterStore" | ||
import { getSearchCriteriaFromFilters } from "app/Components/ArtworkFilter/SavedSearch/searchCriteriaHelpers" | ||
import { SavedSearchEntity } from "app/Components/ArtworkFilter/SavedSearch/types" | ||
|
||
// A hook that returns the required props to be injected in order to use the CreateSavedSearchModal | ||
export const useCreateSavedSearchModalFilters = ({ | ||
entityId, | ||
entitySlug, | ||
entityName, | ||
entityOwnerType, | ||
}: { | ||
entityId: string | ||
entitySlug: string | ||
entityName: string | ||
entityOwnerType: ScreenOwnerType | ||
}) => { | ||
const savedSearchEntity: SavedSearchEntity = { | ||
artists: [{ id: entityId!, name: entityName! }], | ||
owner: { | ||
type: entityOwnerType, | ||
id: entityId!, | ||
slug: entitySlug!, | ||
}, | ||
} | ||
|
||
const filterState = ArtworksFiltersStore.useStoreState((state) => state) | ||
const unitedFilters = getUnitedSelectedAndAppliedFilters(filterState) | ||
const attributes = getSearchCriteriaFromFilters(savedSearchEntity, unitedFilters) | ||
|
||
return { | ||
attributes, | ||
savedSearchEntity, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://artsyproduct.atlassian.net/browse/ONYX-412