Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ONYX-369): navigate to create alerts instead of filers #9350

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Sep 28, 2023

This PR resolves ONYX-369

Description

  • Navigate to create alerts instead of filers on "Create alert" tap when ff is enabled.
Screen.Recording.2023-09-28.at.16.18.48.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • navigate to create alert modal on create alert tap - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Sep 28, 2023
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 28, 2023

This PR contains the following changes:

  • Cross-platform user-facing changes (navigate to create alert modal on create alert tap - mounir)

Generated by 🚫 dangerJS against 8753156

@MounirDhahri MounirDhahri force-pushed the feat/navigate-to-create-alerts-instead-of-filers branch from 2a383ba to 211c42a Compare September 28, 2023 14:18
Comment on lines +122 to +124
const handleCompleteSavedSearch = () => {
// TODO: Get the new count of the artist saved alerts
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MounirDhahri MounirDhahri marked this pull request as ready for review September 28, 2023 14:25
@MounirDhahri MounirDhahri merged commit eda735a into main Oct 4, 2023
@MounirDhahri MounirDhahri deleted the feat/navigate-to-create-alerts-instead-of-filers branch October 4, 2023 07:48
@MounirDhahri
Copy link
Member Author

MounirDhahri commented Oct 4, 2023

I need to merge this to make sure Daria can pick the remaining tasks - glad to address feedback in a separate PR
Edit: Daria is ooo today, so I didn't need to 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants