-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ONYX-369): navigate to create alerts instead of filers #9350
Merged
MounirDhahri
merged 6 commits into
main
from
feat/navigate-to-create-alerts-instead-of-filers
Oct 4, 2023
Merged
feat(ONYX-369): navigate to create alerts instead of filers #9350
MounirDhahri
merged 6 commits into
main
from
feat/navigate-to-create-alerts-instead-of-filers
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/navigate-to-create-alerts-instead-of-filers
branch
from
September 28, 2023 14:18
2a383ba
to
211c42a
Compare
MounirDhahri
commented
Sep 28, 2023
Comment on lines
+122
to
+124
const handleCompleteSavedSearch = () => { | ||
// TODO: Get the new count of the artist saved alerts | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MounirDhahri
deleted the
feat/navigate-to-create-alerts-instead-of-filers
branch
October 4, 2023 07:48
I need to merge this to make sure Daria can pick the remaining tasks - glad to address feedback in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-369
Description
Screen.Recording.2023-09-28.at.16.18.48.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.