chore: simplify routing logic [Part 1] #11178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/simplify-screens-registering
branch
from
68301ce to
2f34cca
Compare
This was referenced Nov 25, 2024
damassi
reviewed
Nov 25, 2024
| Component, | ||
| options = {}, | ||
| Queries, | ||
| }: { |
damassi
reviewed
Nov 25, 2024
| WorksForYou: reactModule({ | ||
| Component: WorksForYouQueryRenderer, | ||
| Queries: [WorksForYouScreenQuery], | ||
| }), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we are getting to the parts that matter. In this PR I am suggesting an incremental step to our Appregistry modules to help us move towards a more common definition for our modules.
I wanted to keep this PR's context small so I am making tiny changes here: (The PR looks big but it's actually the same change many times)
reactModulefunction to accept a single argument (as a subject) instead of multiple argumentsSo instead of
reactModule(Component, ViewOptions, Queries), we will havereactModule({Component, options, Queries }). This will help us avoid cases likereactModule(Component, {}, Quries)This change will help us avoid maintaining 2 props and rely on the default option that comes from react-navigation.
Reasoning: https://github.com/artsy/eigen/blob/main/src/app/Navigation/Utils/isHeaderShown.tsx
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.