Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide header on activity screen #11190

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: hide header on activity screen #11190

merged 1 commit into from
Nov 25, 2024

Conversation

MounirDhahri
Copy link
Member

Description

This PR fixes an issue introduced here #11178
I accidentally not add headerShown: false to the activity list.

Header Header
Simulator Screenshot - iPhone 16 Pro - 2024-11-25 at 16 21 53 Simulator Screenshot - iPhone 16 Pro - 2024-11-25 at 16 21 47

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a [feature flag], or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an [app state migration], or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

#nochangelog

@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Nov 25, 2024
@MounirDhahri MounirDhahri self-assigned this Nov 25, 2024
@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

✅ No changelog changes

Generated by 🚫 dangerJS against cb8b52b

@MounirDhahri MounirDhahri merged commit 1830752 into main Nov 25, 2024
5 of 7 checks passed
@MounirDhahri MounirDhahri deleted the fix/activity-screen-double-header branch November 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olerichter00 olerichter00 Awaiting requested review from olerichter00

Assignees

@MounirDhahri MounirDhahri

Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MounirDhahri @ArtsyOpenSource