Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poly: add specific unit tests and simplify DensePolynomial addition #869

Merged
merged 6 commits into from
Nov 12, 2024
Merged

poly: add specific unit tests and simplify DensePolynomial addition #869

merged 6 commits into from
Nov 12, 2024

Conversation

tcoratger
Copy link
Contributor

Description

add specific unit tests and simplify DensePolynomial addition

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tcoratger tcoratger requested review from a team as code owners November 12, 2024 18:38
@tcoratger tcoratger requested review from z-tech, Pratyush and tyshko-rostyslav and removed request for a team November 12, 2024 18:38
Pratyush
Pratyush reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! only 1 minor comment.

Pratyush
Pratyush approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pratyush Pratyush added this pull request to the merge queue Nov 12, 2024
Merged via the queue into arkworks-rs:master with commit fd6a826 Nov 12, 2024
37 checks passed
@tcoratger tcoratger mentioned this pull request Nov 12, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@tyshko-rostyslav tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @Pratyush