Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poly: unit tests and refac for DensePolynomial addition mixed #870

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

poly: unit tests and refac for DensePolynomial addition mixed #870

wants to merge 4 commits into from

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger commented Nov 12, 2024 •
edited
Loading

Description

unit tests and refac for DensePolynomial addition mixed

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tcoratger tcoratger requested review from a team as code owners November 12, 2024 22:15
@tcoratger tcoratger requested review from mmagician, weikengchen and tyshko-rostyslav and removed request for a team November 12, 2024 22:15
tcoratger
tcoratger commented Nov 12, 2024
View reviewed changes
poly/src/lib.rs Outdated Show resolved Hide resolved
tcoratger
tcoratger commented Nov 12, 2024
View reviewed changes
poly/src/polynomial/univariate/dense.rs
if self.is_zero() {
self.coeffs.truncate(0);
self.coeffs.clear();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #869 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush left review comments

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

@tyshko-rostyslav tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @Pratyush