Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket接続のclosing handshakeを行う #78

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

kobkaz
Copy link
Contributor

@kobkaz kobkaz commented Apr 22, 2024

close を呼ぶことで適切にclosing handshake をする

コードが大きくなったので同時にリファクタしている

@kobkaz kobkaz self-assigned this Apr 22, 2024
@kobkaz kobkaz requested a review from KOBA789 April 22, 2024 10:22
@KOBA789 KOBA789 added this to the 0.4.0 milestone Apr 22, 2024
@KOBA789
Copy link
Member

KOBA789 commented Apr 22, 2024

ref: #73

Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは優雅

@KOBA789 KOBA789 merged commit 86eb08a into main Apr 22, 2024
1 check passed
@KOBA789 KOBA789 deleted the graceful_shutdown branch April 22, 2024 10:53
This was referenced Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants