Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用体験の向上 #73

Closed
kobkaz opened this issue Apr 22, 2024 · 4 comments
Closed

使用体験の向上 #73

kobkaz opened this issue Apr 22, 2024 · 4 comments
Assignees
@kobkaz
Labels
enhancement New feature or request
Milestone
0.4.0

Comments

@kobkaz
Copy link
Contributor

kobkaz commented Apr 22, 2024

kbleに「行儀のよい」振る舞いをさせて、デバッグ等をしやすくしたい

今考えている改善（概ね優先順位の順）

  • わかりやすいエラーメッセージをだす
    • kble本体でもtracingを有効にする
  • WebSocket接続をgracefulに終了する
    • 現状 Connection reset without closing handshake が出力の大半を占めている
  • 子プロセスをwaitする
  • SIGTERM等を受けた場合も適切に終了する
    • WebSocketのgracefulな終了や子プロセスの終了を含む
  • 自動再接続
    • できれば
@kobkaz kobkaz self-assigned this Apr 22, 2024
@kobkaz kobkaz changed the title 仕様体験の向上 使用体験の向上 Apr 22, 2024
@KOBA789
Copy link
Member

KOBA789 commented Apr 22, 2024

子プロセス wait してないっけ、と思ったらしてなかった……（質悪くてすみません）

@KOBA789 KOBA789 added this to the 0.4.0 milestone Apr 22, 2024
@KOBA789 KOBA789 added the enhancement New feature or request label Apr 22, 2024
@KOBA789 KOBA789 mentioned this issue Apr 22, 2024
Merged
@sksat
Copy link
Member

sksat commented Nov 19, 2024

これは以下でやったかんじなのかな

@KOBA789
Copy link
Member

KOBA789 commented Nov 19, 2024

元のアイデアをすべてやったわけではないけど、それらで部分的に実現したという認識

@kobkaz
Copy link
Contributor Author

kobkaz commented Nov 19, 2024

そうですね、一区切りでよいと思います

@kobkaz kobkaz closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kobkaz kobkaz

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
3 participants
@KOBA789 @kobkaz @sksat