Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

簡単なリファクタ #74

Merged
merged 4 commits into from
Apr 22, 2024
Merged

簡単なリファクタ #74

merged 4 commits into from
Apr 22, 2024

Conversation

kobkaz
Copy link
Contributor

@kobkaz kobkaz commented Apr 22, 2024

今後の変更の準備として、いくつかの簡単なリファクタリングとtracing-subscriberの設定をする

  • spaghetti::Config::runapp::run に移動
  • configファイルの妥当性検証を、configファイル読み込み直後に行う
    • これによりrun 関数内の "No such plug" エラーは unreachable! になる
  • tracing-subscriberを設定する

@kobkaz kobkaz requested a review from sksat as a code owner April 22, 2024 02:15
@kobkaz kobkaz requested a review from KOBA789 April 22, 2024 02:17
@kobkaz kobkaz self-assigned this Apr 22, 2024
@KOBA789
Copy link
Member

KOBA789 commented Apr 22, 2024

すくなくともアイデアはとてもよさそうです。コードの中身はまだ見られてないです。
このあとレビューします。

Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう!

@KOBA789 KOBA789 added this to the 0.4.0 milestone Apr 22, 2024
@KOBA789
Copy link
Member

KOBA789 commented Apr 22, 2024

@kobkaz Cargo.toml が conflict しちゃってるのでそこだけ解決お願いします。マージはこっちでやります。

@kobkaz
Copy link
Contributor Author

kobkaz commented Apr 22, 2024

conflict解消しました

kble/src/app.rs Outdated Show resolved Hide resolved
@KOBA789 KOBA789 merged commit 80a13f1 into main Apr 22, 2024
1 check passed
@KOBA789 KOBA789 deleted the minor_refactors branch April 22, 2024 09:57
This was referenced Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants