Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Added chart values deprecation parameters #2954

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −3
Open

feat(argo-cd): Added chart values deprecation parameters #2954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d44be21
Added chart values deprecation parameters. This will simplify updates…
JanisOrlovs Oct 1, 2024
60b68c6
Added chart values deprecation parameters. This will simplify updates…
JanisOrlovs Oct 1, 2024
760d9d9
Update charts/argo-cd/templates/argocd-server/deprecation.yaml
JanisOrlovs Oct 2, 2024
532299b
Update charts/argo-cd/Chart.yaml
JanisOrlovs Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/argo-cd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
kubeVersion: ">=1.25.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 7.6.7
version: 7.7.0
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -26,5 +26,5 @@
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: fixed
description: Arrange for ApplicationSet in any namespace.
- kind: added
description: Added values deprecation pattern for Chart, to make easier upgrade process.

Check failure on line 30 in charts/argo-cd/Chart.yaml

View workflow job for this annotation

GitHub Actions / chart-test 

30:95 [new-line-at-end-of-file] no new line character at the end of file
1 change: 1 addition & 0 deletions charts/argo-cd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ NAME: my-release
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| apiVersionOverrides | object | `{}` | |
| checkDeprecation | bool | `false` | Checks if any deprecated values are used |
| crds.additionalLabels | object | `{}` | Addtional labels to be added to all CRDs |
| crds.annotations | object | `{}` | Annotations to be added to all CRDs |
| crds.install | bool | `true` | Install and upgrade CRDs |
Expand Down
5 changes: 5 additions & 0 deletions charts/argo-cd/templates/argocd-server/deprecation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{{- if .Values.checkDeprecation }}
{{- if .Values.server.config }}
{{ fail "`server.config` no longer exists. It has been renamed to `configs`" }}
{{- end }}
{{- end }}
JanisOrlovs marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions charts/argo-cd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3721,3 +3721,7 @@ notifications:
# For more information: https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/triggers/#default-triggers
# defaultTriggers: |
# - on-sync-status-unknown

# -- Checks if any deprecated values are used
checkDeprecation: false

Loading