feat(argo-cd): Added chart values deprecation parameters #2954
Conversation
JanisOrlovs
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
… for changes in charts. Pattern copied from https://github.com/jenkinsci/helm-charts/blob/jenkins-5.7.1/charts/jenkins/templates/deprecation.yaml Signed-off-by: Jānis Orlovs <[email protected]>
… for changes in charts. Pattern copied from https://github.com/jenkinsci/helm-charts/blob/jenkins-5.7.1/charts/jenkins/templates/deprecation.yaml v1 Signed-off-by: Jānis Orlovs <[email protected]>
JanisOrlovs
force-pushed
the
check-depreciation-for-argo
branch
from
5e565cc
to
60b68c6
Compare
JanisOrlovs
changed the title
jmeridth
changed the title
yu-croco
changed the title
Co-authored-by: Jason Meridth <[email protected]> Signed-off-by: Jānis Orlovs <[email protected]>
Co-authored-by: Jason Meridth <[email protected]> Signed-off-by: Jānis Orlovs <[email protected]>
|
Maybe makes sense to enable by default? |
I'd be okay with that. /cc @mkilchhofer @yu-croco @pdrastil @tico24 to ensure +2 on this decision. |
|
@JanisOrlovs can you please fix the new lines (needed at end of files) to fix linting errors? |
No strict opinion from my side, I tend to not enable it by default. We normally print warnings in the charts NOTES file |
@JanisOrlovs thats a no to enable by default. |
|
@JanisOrlovs any chance to fix the linting error? |
Added chart values deprecation parameters. This will simplify updates for changes in charts.
Pattern copied from https://github.com/jenkinsci/helm-charts/blob/jenkins-5.7.1/charts/jenkins/templates/deprecation.yaml
By default now disabled, in future release will put as enabled
Checklist: